Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: limit input file change detection to $GOPATH/$GOROOT #23390

Closed
rsc opened this issue Jan 9, 2018 · 1 comment
Closed

cmd/go: limit input file change detection to $GOPATH/$GOROOT #23390

rsc opened this issue Jan 9, 2018 · 1 comment
Labels
FrozenDueToAge release-blocker
Milestone
Go1.10

Comments

@rsc
Copy link
Contributor

rsc commented Jan 9, 2018

Tests that stat /dev/null on OS X are uncacheable because /dev/null's mtime is the current time. More generally I don't believe we should try to detect changes outside the package's workspace tree, which is to say outside $GOROOT for packages in GOROOT or outside the specific GOPATH subtree root for packages in one of the directories listed in GOPATH.

Sent CL 87015 to do that.
@rsc rsc self-assigned this Jan 9, 2018
@rsc rsc added this to the Go1.10 milestone Jan 9, 2018
@gopherbot
Copy link

Change https://golang.org/cl/87015 mentions this issue: cmd/go: limit test input file change detection to local GOROOT/GOPATH tree

@golang golang locked and limited conversation to collaborators Jan 10, 2019
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
2 participants
@rsc @gopherbot