-
Notifications
You must be signed in to change notification settings - Fork 18k
dist: provide one-line installer #23381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Something that bothered me about the 1.10 beta installer is that, while definitely convenient, it didn’t feel very official. Are there any possible features to make the experience feel more secure? I understand that downloading an archive from the download page or doing just about anything on the Internet also requires the same level of trust (why were the files hosted on something other than dl.google.com for awhile?), but a thought is the convenience offered by a 1-line installer could make people more complacent in their sourcing of it. |
Are you referring to #22648? I agree that it looked sketchy, which is part of why I filed the bug to get it changed. |
Yes that was it, thanks for the change. I trusted the redirector.gvt1.com link because of the https://golang.org/dl/ URL and Chrome saying the cert is valid there, but I thought about it for a moment. Downloading a 1-click downloader binary over HTTPS from a trustworthy URL page (even pointing at gvt1.com) is the only security I'd actually expect, but the previous comment seemed worth sharing here. |
@pciet regarding safety/trust - I'd suggest opening a new bug to discuss that that, but the short answer is that we do provide GPG signatures for tarballs (add .asc to any those download URLs). They're signed with the Google private key. Some more docs for that may be warranted. |
This bug has little description. What is this one-line installer? What problem is supposed to solve? On which operating systems? Is there any kind of doc/spec on how it should work? |
@rasky It's intended to be a single short command that anyone can run to install or update Go on their system. It's intended to be the Go equivalent of https://www.rustup.rs/ . |
@ianlancetaylor comment in the other issue:
I was referring to what @broady said above. Maybe explaining good security practices, such as how to verify the GPG signature, could be part of the documentation for the tool. This could be on the website and in the program as help text. |
I've been talking with @spf13 about the one-line installer. If the idea is to use
The idea would be to set the necessary environment variables -- This would presumably resolve #21277. Granted, it's not as nice as:
but |
if we rename it from go_installer to "gi" it shortens the command a lot :) It's a fundamentally different approach from the rustup.sh approach. The rustup approach can't set variables in the current shell which is a major stumbling block for users. |
Here is an attempt at resolving #21277 as we've discussed. /cc @spf13 @broady @Deleplace |
I saw that no progress was made with |
A few questions I have about a potential tool like this:
|
I think this is a great idea, but continuing the comparison with Rust, that has 3 tools:
The Perhaps a in the same naming spirit, a |
fyi - getgo is deprecated. |
We all agree we want a 1-line installer. tools/cmd/getgo is a start but has work to do. This is the tracking bug for shipping it (and advertising it on the install page).
The text was updated successfully, but these errors were encountered: