Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go/internal/work: golang fails to parse pkgonfig 1.4+ output #23373

Closed
jcajka opened this issue Jan 8, 2018 · 1 comment
Closed

cmd/go/internal/work: golang fails to parse pkgonfig 1.4+ output #23373

jcajka opened this issue Jan 8, 2018 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone

Comments

@jcajka
Copy link
Contributor

jcajka commented Jan 8, 2018

What version of Go are you using (go version)?

1.10beta1

Does this issue reproduce with the latest release?

yes, AFAIK this affects all supported versions, IMHO backport to all of them would be appropriate

What operating system and processor architecture are you using (go env)?

linux/*

What did you do?

Run test suite on linux system with most recent pkgconfig(1.4+) installed.

What did you expect to see?

Tests to pass.

What did you see instead?

ok  	cmd/fix	0.025s
--- FAIL: TestCgoPkgConfig (0.20s)
	go_test.go:310: running testgo [env PKG_CONFIG]
	go_test.go:319: standard output:
	go_test.go:320: pkg-config
		
	go_test.go:310: running testgo [run /tmp/gotest291662432/foo.go]
	go_test.go:323: standard error:
	go_test.go:324: # command-line-arguments
		gcc: error: '-DDEFINED_FROM_PKG_CONFIG=hello: No such file or directory
		gcc: error: world': No such file or directory
		
	go_test.go:333: go [run /tmp/gotest291662432/foo.go] failed unexpectedly: exit status 2
FAIL
FAIL	cmd/go	39.947s
ok  	cmd/go/internal/generate	0.021s

FYI CL fixing this is on the way

@gopherbot
Copy link

Change https://golang.org/cl/86541 mentions this issue: cmd/go/internal/work : improve pkgconfig support to work with latest pkgconf

@ianlancetaylor ianlancetaylor added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Mar 28, 2018
@ianlancetaylor ianlancetaylor added this to the Go1.11 milestone Mar 28, 2018
@golang golang locked and limited conversation to collaborators Apr 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Development

No branches or pull requests

3 participants