Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/test2json: cannot tell when benchmark starts running #23352

Closed
rsc opened this issue Jan 5, 2018 · 1 comment
Closed

cmd/test2json: cannot tell when benchmark starts running #23352

rsc opened this issue Jan 5, 2018 · 1 comment
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Milestone
Go1.10

Comments

@rsc
Copy link
Contributor

rsc commented Jan 5, 2018

For #23346, sent a CL that handles BENCH output, but it is still open whether and how to indicate that a benchmark has started running. The json streaming is actually harmful here, in that it processes the output line-at-a-time, so that you don't even see the BenchmarkFoo line fragment that is printed at the start of the benchmark, until the end of the benchmark.

Thinking.
@rsc rsc added this to the Go1.10 milestone Jan 5, 2018
@rsc rsc added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Jan 5, 2018
@rsc rsc mentioned this issue Jan 5, 2018
Closed
@gopherbot
Copy link

Change https://golang.org/cl/86695 mentions this issue: cmd/test2json: emit Benchmark name output early

@golang golang locked and limited conversation to collaborators Jan 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made.
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
2 participants
@rsc @gopherbot