Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/crypto/acme: Update to ACME v2 #23342

Closed
titanous opened this issue Jan 5, 2018 · 4 comments
Closed

x/crypto/acme: Update to ACME v2 #23342

titanous opened this issue Jan 5, 2018 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Unreleased

Comments

@titanous
Copy link
Member

titanous commented Jan 5, 2018

Let's Encrypt has a staging endpoint up for ACME v2 (aka IETF ACME, will be published as an RFC soon). I'm going to start rewriting/updating the client to support the new API, with the thought that we can just replace the previous implementation when Let's Encrypt launches their production v2 endpoint next month.

The package documentation explicitly states there are no stability guarantees and there are effectively no other public ACME servers, so I don't think there's any reason to keep the old implementation around. I will avoid making any changes to public APIs unless necessary.

/cc @x1ddos
@titanous titanous added this to the Unreleased milestone Jan 5, 2018
@titanous titanous self-assigned this Jan 5, 2018
@bradfitz
Copy link
Contributor

bradfitz commented Jan 5, 2018

Sounds good.

It's more important that the x/crypto/acme/autocert package not change at all. If x/crypto/acme has to change a bit, I'm fine with that.

Thanks!

@bradfitz bradfitz added the NeedsFix The path to resolution is known, but the work has not been done. label Jan 5, 2018
@x1ddos
Copy link

x1ddos commented Jan 5, 2018

This is a duplicate of #21081. Let's use the original issue.

@mvdan
Copy link
Member

mvdan commented Jan 5, 2018

Thanks for pointing that out.

@mvdan mvdan closed this as completed Jan 5, 2018
@x1ddos
Copy link

x1ddos commented Jan 5, 2018

@titanous I think there might actually be other ACME-compatible servers but even if there aren't any, I know for a fact there exist non-public implementations. I'd like to keep v1 working.

@titanous titanous mentioned this issue Jan 7, 2018
Closed
@golang golang locked and limited conversation to collaborators Jan 5, 2019
@titanous titanous reopened this May 7, 2019
@titanous titanous closed this as completed May 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
5 participants
@bradfitz @titanous @x1ddos @mvdan @gopherbot