Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/oauth2: Add Spotify Endpoints #23338

Closed
FenwickElliott opened this issue Jan 4, 2018 · 8 comments
Closed

x/oauth2: Add Spotify Endpoints #23338

FenwickElliott opened this issue Jan 4, 2018 · 8 comments

Comments

@FenwickElliott
Copy link

Adding Spotify endpoints as per documentation: https://developer.spotify.com/web-api/authorization-guide/

@odeke-em odeke-em changed the title Adding Spotify Endpoints to /x/oauth2/spotify x/oauth2: Add Spotify Endpoints Jan 4, 2018
@gopherbot gopherbot added this to the Unreleased milestone Jan 4, 2018
@odeke-em
Copy link
Member

odeke-em commented Jan 4, 2018

@FenwickElliott please feel free to mail a CL, just in case you haven't yet seen it, please see https://golang.org/doc/contribute.html and in particular, after setting up the initial Gerrit workflow, then https://golang.org/doc/contribute.html#subrepos -- that should take a couple of steps to setup, not too many.

I'll also tag @rakyll @broady

@FenwickElliott
Copy link
Author

Thanks, I tried to be very deliberate about setting myself up correctly according to the Contribution Guide.

However when I run the global tests according to https://golang.org/doc/contribute.html#Testing I am getting failures (exactly the same errors with or without my contribution). And to be honest the fails are beyond my scope. Any advice on how I should proceed?

@bradfitz
Copy link
Contributor

bradfitz commented Jan 4, 2018

No need to run the global tests for contributing to the oauth2 repo. Just run the oauth2 tests.

@odeke-em
Copy link
Member

odeke-em commented Jan 4, 2018

Thank you @FenwickElliott for the feedback and congrats on making it that far! IMHO don't worry about them being "beyond my scope", soon they won't be anymore ;) Let's try to isolate out the noise, those tests are relevant for the main Go project. For your contributions let's take a look instead at https://golang.org/doc/contribute.html#subrepos.

Seems like at this point, your Gerrit is correctly setup, so if you run

go get -d golang.org/x/oauth2/...
$GOPATH/src/golang.org/x/oauth2

you can then make your change following say what was done at https://github.com/golang/oauth2 with the respective directories for example for Paypal, there is a directory paypal and it's file https://github.com/golang/oauth2/blob/master/paypal/paypal.go

Once you've made a similar change, then please mail it with Gerrit and tag me, and I'll help out more there.

Please let me know if this makes sense or if at any point you need some clarification.

@odeke-em
Copy link
Member

odeke-em commented Jan 4, 2018

Aha @bradfitz you beat me to the response ;)

@FenwickElliott
Copy link
Author

Great, thank you. That makes perfect sense and is a massive relief.

@FenwickElliott
Copy link
Author

Thanks for all your help, really (both of you).

I've mailed to so hopefully we're all good. :)

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/86250 mentions this issue: spotify: add Spotify endpoints

@golang golang locked and limited conversation to collaborators Jan 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants