Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: use NEGL for DIVL #23310

Closed
mdempsky opened this issue Jan 2, 2018 · 1 comment
Closed

cmd/compile: use NEGL for DIVL #23310

mdempsky opened this issue Jan 2, 2018 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.11

Comments

@mdempsky
Copy link
Member

mdempsky commented Jan 2, 2018

When emitting the code to handle x / -1 on amd64, we should use the size-appropriate negation operation. For example, NEGL for DIVL.

This probably also means using NEGW for DIVW, which might also apply to the 386 backend?

Fixing this should allow reverting https://go-review.googlesource.com/c/go/+/85736. See also #23305.

/cc @TocarIP @cherrymui
@mdempsky mdempsky added this to the Go1.11 milestone Jan 2, 2018
@mdempsky mdempsky mentioned this issue Jan 2, 2018
Closed
@gopherbot
Copy link

Change https://golang.org/cl/96815 mentions this issue: cmd/compile/internal/amd64: use appropriate NEG for div

@golang golang locked and limited conversation to collaborators Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
2 participants
@mdempsky @gopherbot