Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/perf/benchstat: html output renders garbled "µ" characters in Firefox #23308

Closed
myartsev opened this issue Jan 2, 2018 · 2 comments
Closed

x/perf/benchstat: html output renders garbled "µ" characters in Firefox #23308

myartsev opened this issue Jan 2, 2018 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@myartsev
Copy link

myartsev commented Jan 2, 2018

In Firefox, the html output for benchstat renders garbled "µ" characters and the following warning:

The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol.

garbled

One resolution would to be to specify the html encoding
<meta charset="utf-8"/>
fixed
@gopherbot gopherbot added this to the Unreleased milestone Jan 2, 2018
@namusyaka
Copy link
Member

Your solution looks reasonable to me. Actually, go tool cover -html output has specified html encoding which would be something like:

<!DOCTYPE html>
<html>
	<head>
		<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
....

Also, the output of benchstats seems not to be valid as w3c html5 specification.
I'm going to fix the problems.

@gopherbot
Copy link

Change https://golang.org/cl/85796 mentions this issue: benchstat: specify meta charset=utf-8 to avoid garbled text

@golang golang locked and limited conversation to collaborators Jan 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@namusyaka @myartsev @gopherbot