New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mime/multipart: Header populated by Reader.NextPart() should not modify the order of the body headers #23290
Labels
Comments
Header ordering has been raised several times over the years and the response has been that the http spec does not define a header order.
If we were to change the order of headers to be ordered, which order should we choose? Unordered headers aren’t they helpful for your use, but neither are headers ordered in the wrong order for your application. You can see that promising _an_ order would lead to feature requests to alter that order.
For you application I recommend that you sort the headers according to your requirement explicitly. Then you’re not reliant on an implant detail of the http package which may change.
… On 31 Dec 2017, at 16:24, 陳大衛 ***@***.***> wrote:
Reader.NextPart sometimes alter the order of the headers of the body which cause my app that utilize digital signature fail to verify because of message alteration.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
I mean, had the lib modified my data? |
dawud-tan
changed the title
Header populated by Reader.NextPart() sometimes reorder the headers of the body
Header populated by Reader.NextPart() should not modify the order of the body headers
Dec 31, 2017
What is probably happening is data is being read into a map, which will remove any ordering. Based on similar issues raised in the past I don’t expect that this one will be accepted so my advice is to asset the ordering of headers you need explicitly.
… On 31 Dec 2017, at 17:08, 陳大衛 ***@***.***> wrote:
I mean, had the modified my data?
could it be make to leave the data intact?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub, or mute the thread.
|
well, thanks for the info, so, the issue could be closed. |
odeke-em
changed the title
Header populated by Reader.NextPart() should not modify the order of the body headers
mime/multipart: Header populated by Reader.NextPart() should not modify the order of the body headers
Dec 31, 2017
I don't understand what this bug report is about (the bug template was deleted and there's no repro or code snippet), but per the last comment, I will close this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Reader.NextPart sometimes alter the order of the headers of the body which cause my app that utilize digital signature fail to verify because of message alteration.
The text was updated successfully, but these errors were encountered: