Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/text/currency: fix date format on example #23233

Closed
navossoc opened this issue Dec 24, 2017 · 1 comment
Closed

x/text/currency: fix date format on example #23233

navossoc opened this issue Dec 24, 2017 · 1 comment
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@navossoc
Copy link

navossoc commented Dec 24, 2017 •
edited

What version of Go are you using (go version)?

go version go1.9.2 windows/amd64

Does this issue reproduce with the latest release?

Yes

What operating system and processor architecture are you using (go env)?

set GOARCH=amd64
set GOBIN=
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=C:\Users\Rafael\go
set GORACE=
set GOROOT=C:\Go
set GOTOOLDIR=C:\Go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set GOGCCFLAGS=-m64 -mthreads -fmessage-length=0
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config

What did you do?

I've created a pull request, but it takes a lot of work to become a contributor to change only two numbers.
There is more info here: golang/text#3

What did you expect to see?

// GBP is used in GB since: 1694-07-27
// GIP is used in GI since: 1713-01-01
// USD is used in US since: 1792-01-01

What did you see instead?

// GBP is used in GB since: 1694-07-07
// GIP is used in GI since: 1713-01-01
// USD is used in US since: 1792-01-01
@navossoc navossoc changed the title golang.org/x/text/currency: fix date format on example x/text/currency: fix date format on example Dec 24, 2017
@gopherbot gopherbot added this to the Unreleased milestone Dec 24, 2017
@gopherbot
Copy link

Change https://golang.org/cl/85398 mentions this issue: currency: fix format in example

@golang golang locked and limited conversation to collaborators Dec 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@navossoc @gopherbot