Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math/big: specialize Karatsuba implementation for squaring #23221

Closed
griesemer opened this issue Dec 22, 2017 · 6 comments
Closed

math/big: specialize Karatsuba implementation for squaring #23221

griesemer opened this issue Dec 22, 2017 · 6 comments

Comments

@griesemer
Copy link
Contributor

We may be able to get some more performance out of the multiplication code when we know that both operands are the same.

Follow-up for #13745.

@griesemer griesemer added this to the Unreleased milestone Dec 22, 2017
@griesemer griesemer self-assigned this Dec 22, 2017
@mvdan
Copy link
Member

mvdan commented Jan 6, 2018

@griesemer perhaps you meant to milestone this as Unplanned, not Unreleased?

@ALTree ALTree modified the milestones: Unreleased, Unplanned Jan 8, 2018
@gopherbot
Copy link

Change https://golang.org/cl/105075 mentions this issue: math/big: specialize Karatsuba implementation for squaring

@bradfitz bradfitz modified the milestones: Unplanned, Go1.11 May 9, 2018
@bradfitz
Copy link
Contributor

bradfitz commented May 9, 2018

Has pending CL so marking release-blocker for Go 1.11. @griesemer can of course choose to not accept it for Go 1.11, but it was mailed pre-freeze so is okay for Go 1.11 and is just awaiting some review.

@griesemer
Copy link
Contributor Author

I will review this but it's certainly not a release blocker. The code works fine as is and the new code is not that much faster.

@bradfitz
Copy link
Contributor

We use "release-blocker" also to mean an issue has a CL and needs attention before the release, otherwise they get bulk moved to Go 1.12 and things aren't given attention. So I'm going to re-apply "release-blocker" to this to protect it from bulk moves. Again, this doesn't need to be in Go 1.11 if you don't want it. It just needs to be decided by a human one way or another for Go 1.11 because a human spent the time to mail a CL.

@gopherbot
Copy link

Change https://golang.org/cl/114335 mentions this issue: math/big: reduce allocations in Karatsuba case of sqr

gopherbot pushed a commit that referenced this issue May 23, 2018
For #23221.

Change-Id: If55dcf2e0706d6658f4a0863e3740437e008706c
Reviewed-on: https://go-review.googlesource.com/114335
Run-TryBot: Robert Griesemer <gri@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Robert Griesemer <gri@golang.org>
@golang golang locked and limited conversation to collaborators May 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants