Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: TestInterfaceHardwareAddrWithWmic fail on non-english Windows #23191

Closed
mattn opened this issue Dec 20, 2017 · 4 comments
Closed

net: TestInterfaceHardwareAddrWithWmic fail on non-english Windows #23191

mattn opened this issue Dec 20, 2017 · 4 comments
Labels
FrozenDueToAge

Comments

@mattn
Copy link
Member

mattn commented Dec 20, 2017

What version of Go are you using (go version)?

go version devel +3aeb3950a9 Mon Dec 18 20:24:12 2017 +0000 windows/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

set GOARCH=amd64
set GOBIN=
set GOCACHE=C:\Users\mattn\AppData\Local\go-build
set GOEXE=.exe
set GOHOSTARCH=amd64
set GOHOSTOS=windows
set GOOS=windows
set GOPATH=c:/dev/go
set GORACE=
set GOROOT=C:\go
set GOTMPDIR=
set GOTOOLDIR=C:\go\pkg\tool\windows_amd64
set GCCGO=gccgo
set CC=gcc
set CXX=g++
set CGO_ENABLED=1
set CGO_CFLAGS=-g -O2
set CGO_CPPFLAGS=
set CGO_CXXFLAGS=-g -O2
set CGO_FFLAGS=-g -O2
set CGO_LDFLAGS=-g -O2
set PKG_CONFIG=pkg-config
set GOGCCFLAGS=...gg

What did you do?

go test -run TestInterfaceHardwareAddrWithWmic on src/net.

What did you expect to see?

pass ok

What did you see instead?

not ok

This issue is related on #23153. This test fail to match name of interface since wmic command output DBCS (double byte character set) when redirect to pipe. But wmic command output utf-16 when redirect to file. So the test should fix to get output from file.
@gopherbot
Copy link

Change https://golang.org/cl/84935 mentions this issue: net: redirect output out of wmic command to file on Windows

@alexbrainman
Copy link
Member

not ok

Thank you for creating the issue. Please provide the output of the error message. Maybe provide a screen shot?

I will let @johnsonj decide what to about his CL 84696 before we deal with this issue.

Alex

@gopherbot
Copy link

Change https://golang.org/cl/85315 mentions this issue: Revert "net: enable TestInterfaceHardwareAddrWithGetmac on all windows versions"

gopherbot pushed a commit that referenced this issue Dec 25, 2017
@johnsonj @alexbrainman
net: revert CL 82975
46c5856 
this solution as it stands doesn't work with
non-english device names (#23191 (which has a fix))
and names some devices differently (#23153) probably due to the
fact that this test previously only ran on Server 2008.

Re-opens #20073

Change-Id: I5c36774ddd85ac07620b4015372d564acbb169ad
Reviewed-on: https://go-review.googlesource.com/85315
Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
@ianlancetaylor
Copy link
Contributor

I believe this is fixed, in that the test no longer fails because it is no longer run.

@golang golang locked and limited conversation to collaborators Mar 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mattn @ianlancetaylor @gopherbot @alexbrainman