Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/go/ssa/interp: tests consistently failing on darwin #23166

Closed
mvdan opened this issue Dec 18, 2017 · 10 comments
Closed

x/tools/go/ssa/interp: tests consistently failing on darwin #23166

mvdan opened this issue Dec 18, 2017 · 10 comments
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Milestone
Go1.13

Comments

@mvdan
Copy link
Member

mvdan commented Dec 18, 2017

Spotted on a recent x/tools CL: https://storage.googleapis.com/go-build-log/2de98eb8/darwin-amd64-10_11_1d3b7b4f.log

[...]
Input: static.go
PASS
Input: callstack.go
panic: runtime error: invalid memory address or nil pointer dereference
FAIL
To trace execution, run:
% go build golang.org/x/tools/cmd/ssadump && ./ssadump -build=C -test -run --interp=T callstack.go

The following tests failed:
	boundmeth.go
	complit.go
	coverage.go
	defer.go
	initorder.go
	range.go
	recover.go
	callstack.go
--- FAIL: TestTestdataFiles (23.62s)
	interp_test.go:231: interp.Interpret([testdata/boundmeth.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/complit.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/coverage.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/defer.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/initorder.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/range.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/recover.go]) failed: exit code was 2
	interp_test.go:231: interp.Interpret([testdata/callstack.go]) failed: exit code was 2
FAIL
FAIL	golang.org/x/tools/go/ssa/interp	24.378s

The build dashboard shows that this has been happening since December 10th: https://build.golang.org/?repo=golang.org%2fx%2ftools

It's not immediately obvious if it was a change in this repo or a change in Go that introduced this. Or if something is up with the machines.

/cc @alandonovan @bradfitz
@gopherbot gopherbot added this to the Unreleased milestone Dec 18, 2017
@mvdan mvdan added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin labels Dec 18, 2017
@bradfitz bradfitz modified the milestones: Unreleased, Go1.10 Dec 18, 2017
@bradfitz
Copy link
Contributor

@alandonovan, please fix soon for Go 1.10.

These tests are super fragile.

@alandonovan
Copy link
Contributor

alandonovan commented Dec 18, 2017 via email

@bradfitz
Copy link
Contributor

gomote works for Macs, FWIW.

@bradfitz
Copy link
Contributor

bradfitz commented Jan 3, 2018

This continuing to fail is interfering with development of unrelated packages in x/tools.

@mvdan
Copy link
Member Author

mvdan commented Jan 3, 2018

@bradfitz perhaps those tests could be temporarily disabled on Mac until Alan has time to have a look?

@bradfitz
Copy link
Contributor

bradfitz commented Jan 3, 2018

@mvdan, yup, on it.

@gopherbot
Copy link

Change https://golang.org/cl/85995 mentions this issue: go/ssa/interp: skip tests on darwin until crashes are fixed

gopherbot pushed a commit to golang/tools that referenced this issue Jan 3, 2018
@bradfitz
go/ssa/interp: skip tests on darwin until crashes are fixed
ef037a1 
Updates golang/go#23166

Change-Id: Ie9db70d6f2f8d90817ec3de35e6ca51ec476f949
Reviewed-on: https://go-review.googlesource.com/85995
Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bradfitz bradfitz mentioned this issue Jan 11, 2018
Open
@ianlancetaylor
Copy link
Contributor

It looks we are skipping the tests for now, so this is presumably not a release blocker for 1.10. Shifting to 1.11.

@ianlancetaylor ianlancetaylor modified the milestones: Go1.10, Go1.11 Jan 24, 2018
@griesemer
Copy link
Contributor

Again; not a release-blocker for 1.11.

@griesemer griesemer modified the milestones: Go1.11, Go1.12 Jun 27, 2018
@griesemer griesemer added early-in-cycle A change that should be done early in the 3 month dev cycle. and removed release-blocker labels Jun 27, 2018
@mvdan mvdan modified the milestones: Go1.12, Go1.13 Nov 28, 2018
@bradfitz
Copy link
Contributor

I think this was fixed along with #27292 by golang/tools@e779aa4

I no longer see any darwin reference (no more t.Skip).

@golang golang locked and limited conversation to collaborators Apr 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Darwin
Projects
None yet
Milestone
Go1.13
Development

No branches or pull requests
6 participants
@bradfitz @ianlancetaylor @mvdan @alandonovan @griesemer @gopherbot