Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/maintner: Unknown fields in event #23151

Closed
kevinburke opened this issue Dec 15, 2017 · 10 comments
Closed

x/build/maintner: Unknown fields in event #23151

kevinburke opened this issue Dec 15, 2017 · 10 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@kevinburke
Copy link
Contributor

kevinburke commented Dec 15, 2017 •
edited

Code in question is here in github.go:

		otherJSON, _ := json.Marshal(em)
		e.OtherJSON = string(otherJSON)
		if e.OtherJSON == "{}" {
			e.OtherJSON = ""
		}
		if e.OtherJSON != "" {
			log.Fatalf("Unknown fields in event: %s", e.OtherJSON)
		}
		evts = append(evts, e)

The unknown fields are "requested_reviewer" and "review_requester".

I may take a crack at this as I have more free time now. Probably the way to trigger this is to create a Github pull request and assign someone to review it, maybe on the gddo repository.
@gopherbot gopherbot added this to the Unreleased milestone Dec 15, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Dec 15, 2017
@kevinburke
Copy link
Contributor Author

cc @adams-sarah @andybons @bradfitz

@kevinburke
Copy link
Contributor Author

More:

{
    "dismissed_review": {
        "dismissal_commit_id": null,
        "dismissal_message": "should add this to dev and prod",
        "review_id": 68794584,
        "state": 40
    }
}

@s-mang
Copy link
Contributor

s-mang commented Dec 15, 2017

Hey @kevinburke, I'm not working w/ the Go team anymore, so not maintaining builders.
Please only ping me on these if you think I've got answers that nobody else does. I'm happy to share any knowledge I might have in this case :)
But in general, I'm hoping to keep away from the project for a while.
Thanks!

@kevinburke
Copy link
Contributor Author

Oh okay apologies!

@gopherbot
Copy link

Change https://golang.org/cl/84375 mentions this issue: maintner: add 3 new fields to GithubIssueEvent

@bradfitz
Copy link
Contributor

What is this impacting?

I don't see anything crashing in production.

How did you find this?

@kevinburke
Copy link
Contributor Author

I found it while trying to locally cache several Github repositories for a company I have been working with. Unfortunately the repositories are private. I believe you can reproduce the issue by attempting to sync a Github repository that has a pull request with an assigned reviewer.

@kevinburke
Copy link
Contributor Author

I believe I could trigger it by creating a pull request on e.g. github.com/golang/gddo and assigning it to someone, but I would rather not do this until we know it won't crash production.

@kevinburke
Copy link
Contributor Author

Exact command was:

maintnerd --sync-and-quit --watch-github=OwnerName/RepoName,OwnerName/RepoName2

@bradfitz
Copy link
Contributor

Gotcha.

@golang golang locked and limited conversation to collaborators Dec 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@bradfitz @kevinburke @s-mang @gopherbot