Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

net: UDPConn.WriteMsgUDP fails on Windows XP #23072

Closed
alexbrainman opened this issue Dec 9, 2017 · 10 comments
Closed

net: UDPConn.WriteMsgUDP fails on Windows XP #23072

alexbrainman opened this issue Dec 9, 2017 · 10 comments
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Milestone
Unplanned

Comments

@alexbrainman
Copy link
Member

new windows-386-xp builder on https://build.golang.org fails at commit 29cb57c

https://build.golang.org/log/e18744bedc520329ee61476194bf5020a66ba706

with

--- FAIL: TestUDPConnSpecificMethods (0.02s)
	protoconn_test.go:142: write udp4 127.0.0.1:1138->127.0.0.1:1138: wsasendmsg: An invalid argument was supplied.
--- FAIL: TestWriteToUDP (0.00s)
	udpsock_test.go:168: write udp 127.0.0.1:1282: wsasendmsg: An invalid argument was supplied.
FAIL
FAIL	net	10.336s

As I explained at #10267 (comment) I think we should just skip correspondent parts of the test on Windows XP.

Alex
@bradfitz
Copy link
Contributor

bradfitz commented Dec 9, 2017

What's the proper way to detect XP?

@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. OS-Windows labels Dec 9, 2017
@bradfitz bradfitz added this to the Go1.10 milestone Dec 9, 2017
@alexbrainman
Copy link
Member Author

What's the proper way to detect XP?

Search for isWindowsXP in main repo.

I am going to send a fix for this in a little while. Please wait.

Alex

@alexbrainman
Copy link
Member Author

@bradfitz do we have Windows XP trybot?

Alex

@gopherbot
Copy link

Change https://golang.org/cl/83076 mentions this issue: internal/testenv: introduce IsWindowsXP

@gopherbot
Copy link

Change https://golang.org/cl/83077 mentions this issue: net: skip some tests on Windows XP

@bradfitz
Copy link
Contributor

@alexbrainman, no trybot. We just have a single XP VM currently. Maybe @johnsonj will get Windows Server 2003 working on GCE and then we could have an opt-in Trybot or something.

@alexbrainman
Copy link
Member Author

Cool, I will test my change here, and then we'll submit and see.

Alex

@alexbrainman
Copy link
Member Author

I really do not know how to fix this - I am not even sure if it is possible to fix. I am just skipping broken tests for the moment.

Alex

@bradfitz
Copy link
Contributor

@alexbrainman, that's fine.

gopherbot pushed a commit that referenced this issue Dec 10, 2017
@alexbrainman @bradfitz
internal/testenv: introduce IsWindowsXP
d038da7 
For #23072

Change-Id: I089feafef2900413d46f2358b6e41ab78187eced
Reviewed-on: https://go-review.googlesource.com/83076
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
gopherbot pushed a commit that referenced this issue Dec 10, 2017
@alexbrainman @bradfitz
net: skip some tests on Windows XP
607147d 
Parts of TestUDPConnSpecificMethods and TestWriteToUDP fail, because
UDPConn.WriteMsgUDP is broken on Windows XP. UDPConn.WriteMsgUDP uses
Windows WSASendMsg API, but that call is not implemented on Windows XP (see
https://msdn.microsoft.com/en-us/library/windows/desktop/ms741692(v=vs.85).aspx
for details)

Update #23072

Change-Id: I4e8f149bc62bd87cd7c199e6832b9ce479af0a3e
Reviewed-on: https://go-review.googlesource.com/83077
Run-TryBot: Alex Brainman <alex.brainman@gmail.com>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
@bradfitz bradfitz modified the milestones: Go1.10, Unplanned Dec 10, 2017
@gopherbot
Copy link

Change https://golang.org/cl/94255 mentions this issue: all: drop support for Windows Vista or below

@golang golang locked and limited conversation to collaborators Feb 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge help wanted NeedsFix The path to resolution is known, but the work has not been done. OS-Windows
Projects
None yet
Milestone
Unplanned
Development

No branches or pull requests
3 participants
@bradfitz @gopherbot @alexbrainman