Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/net/html: parser should conform current w3c specifications #23071

Closed
namusyaka opened this issue Dec 9, 2017 · 22 comments
Closed

x/net/html: parser should conform current w3c specifications #23071

namusyaka opened this issue Dec 9, 2017 · 22 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@namusyaka
Copy link
Member

namusyaka commented Dec 9, 2017 •
edited

What version of Go are you using (go version)?

go version devel +25363de Fri Dec 8 16:54:20 2017 +0000 darwin/amd64

Does this issue reproduce with the latest release?

yes

What operating system and processor architecture are you using (go env)?

GOARCH="amd64"
GOBIN=""
GOEXE=""
GOHOSTARCH="amd64"
GOHOSTOS="darwin"
GOOS="darwin"
GOPATH="/Users/numb/workspace/private/go/go"
GORACE=""
GOROOT="/Users/numb/workspace/private/go/go"
GOTOOLDIR="/Users/numb/workspace/private/go/go/pkg/tool/darwin_amd64"
GCCGO="gccgo"
CC="clang"
GOGCCFLAGS="-fPIC -m64 -pthread -fno-caret-diagnostics -Qunused-arguments -fmessage-length=0 -fdebug-prefix-map=/var/folders/6b/hxgkjy5d2d1b1633hq3slp14sf3ny_/T/go-build078552962=/tmp/go-build -gno-record-gcc-switches -fno-common"
CXX="clang++"
CGO_ENABLED="1"
CGO_CFLAGS="-g -O2"
CGO_CPPFLAGS=""
CGO_CXXFLAGS="-g -O2"
CGO_FFLAGS="-g -O2"
CGO_LDFLAGS="-g -O2"
PKG_CONFIG="pkg-config"

What did you do?

While investigating #23064, I noticed that the template element(it's metadata content) was not interpreted correctly.
I'd like to add this element.

[Additonal Notes: 2018/02/15]

We should implement the "in template" insertion mode.

https://play.golang.org/p/k_Q95lq-6T

What did you expect to see?

<html><head><meta/><template>foo</template></head><body></body></html>

What did you see instead?

<html><head><meta/></head><body><template>foo</template></body></html>
@gopherbot gopherbot added this to the Unreleased milestone Dec 9, 2017
@gopherbot
Copy link

Change https://golang.org/cl/83075 mentions this issue: html: add template element as a metadata content

@namusyaka
Copy link
Member Author

Any progress on this?

@namusyaka
Copy link
Member Author

@nigeltao I've commented my opinion at the CL.
Please rename this issue, and then discuss the problem.

@namusyaka namusyaka changed the title x/net/html: parse template element as metadata content x/net/html: parser should conform current w3c specifications Feb 4, 2018
@nigeltao
Copy link
Contributor

nigeltao commented Feb 8, 2018

It (updating x/net/html's HTML5 implementation to the latest algorithmic spec) is a valid issue, but it's probably a non-trivial amount of work, and I don't have much spare time right now. Sorry.

@namusyaka
Copy link
Member Author

If I can put my two cents in, I'd like to get small changes for adding template element correctly.

@namusyaka
Copy link
Member Author

I'm working to incorporate template insertion mode into this implementation.

@namusyaka namusyaka self-assigned this Feb 15, 2018
@namusyaka
Copy link
Member Author

Hmm, I've sent a new CL, but it's not noticed by gopherbot.

Also, the CL has a link of this issue, but it's wrong (not /issue but /issues).
/cc @andybons

@andybons
Copy link
Member

The typo in the issue link has been fixed, just not rolled out yet. Will investigate the former.

@gopherbot
Copy link

Change https://golang.org/cl/94355 mentions this issue: html: update section numbers

gopherbot pushed a commit to golang/net that referenced this issue Feb 16, 2018
@namusyaka @nigeltao
html: update section numbers
2e7f24a 
Updates golang/go#23071

See https://html.spec.whatwg.org/multipage/

Change-Id: I1bde6e07ae9270ba7b320474b9bec8ec09a79f16
Reviewed-on: https://go-review.googlesource.com/94355
Reviewed-by: Nigel Tao <nigeltao@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/94837 mentions this issue: html: update quotes about the list of active formatting elements

gopherbot pushed a commit to golang/net that referenced this issue Feb 16, 2018
@namusyaka @bradfitz
html: update quotes about the list of active formatting elements
136a25c 
See https://html.spec.whatwg.org/multipage/parsing.html#the-list-of-active-formatting-elements

Updates golang/go#23071

Change-Id: I015c394ed34d721e9e4a4d3e797d06d750c1864e
Reviewed-on: https://go-review.googlesource.com/94837
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/94838 mentions this issue: html: fix handling the reset insertion mode

@namusyaka
Copy link
Member Author

I'm going to send the last CL for adding the "in template" insertion mode after resolving CL94838.

@namusyaka
Copy link
Member Author

When importing from chromium's test, I found another problem about the ruby elements and a bit.

I'd like to fix the problems after fixing the original issue about the "in template" inserttion mode.

This was referenced Mar 11, 2018
Open
Open
gopherbot pushed a commit to golang/net that referenced this issue Apr 15, 2018
@namusyaka @nigeltao
html: add "in template" insertion mode support
500e7a4 
See:
https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-intemplate

Updates golang/go#23071

Change-Id: I36529b7cf5d2adf159ed5c471fba9f67890b7eb9
Reviewed-on: https://go-review.googlesource.com/94838
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/107198 mentions this issue: html: add atom.Rb and atom.Rtc

@gopherbot
Copy link

Change https://golang.org/cl/107379 mentions this issue: html: avoid invalid nil pointer access

gopherbot pushed a commit to golang/net that referenced this issue Apr 17, 2018
@namusyaka @nigeltao
html/atom: add atom.Rb and atom.Rtc
3121141 
Updates golang/go#23071

Change-Id: I07aae04757e83a3a03681a2ce92e4cab194ef64a
Reviewed-on: https://go-review.googlesource.com/107198
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
gopherbot pushed a commit to golang/net that referenced this issue Apr 17, 2018
@namusyaka @nigeltao
html: avoid invalid nil pointer access
8d16fa6 
Updates golang/go#23071

Change-Id: I73d7302c5bde4441aa824093fdcce52e8bb51e31
Reviewed-on: https://go-review.googlesource.com/107379
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/107575 mentions this issue: html: handle rb and rtc elements

gopherbot pushed a commit to golang/net that referenced this issue Apr 18, 2018
@namusyaka @nigeltao
html: handle rb and rtc elements
d41e817 
Updates golang/go#23071

Change-Id: Ifef79e077801422eb273af3e5a541c85c63bfce4
Reviewed-on: https://go-review.googlesource.com/107575
Reviewed-by: Nigel Tao <nigeltao@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/120658 mentions this issue: html: fix incorrect implementation for specification

gopherbot pushed a commit to golang/net that referenced this issue Jul 6, 2018
@namusyaka @nigeltao
html: don't ignore the token if the current node is form
32a936f 
See: https://html.spec.whatwg.org/multipage/parsing.html#parsing-main-inbody

Fixes golang/go#25703
Updates golang/go#23071

Change-Id: I09db4c2d07a242cb45c3e37b499c609809dd0b83
Reviewed-on: https://go-review.googlesource.com/120658
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/123776 mentions this issue: html: remove special procedure for <template> in frameset im

@gopherbot
Copy link

Change https://golang.org/cl/123920 mentions this issue: html: don't ignore token when current token is not <template>

gopherbot pushed a commit to golang/net that referenced this issue Aug 11, 2018
@namusyaka @nigeltao
html: don't ignore token when current token is not <template>
c394268 
Updates golang/go#23071

Change-Id: I36b0ee58f61b7de25730e0fb082eeb7ef2787594
Reviewed-on: https://go-review.googlesource.com/123920
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
gopherbot pushed a commit to golang/net that referenced this issue Aug 16, 2018
@namusyaka @nigeltao
html: remove special procedure for <template> in frameset im
aaf6012 
See more details: https://bugs.chromium.org/p/chromium/issues/detail?id=829668

Updates golang/go#23071

Change-Id: Ib9c963269f814c3f21d3784754729df57dcc8f90
Reviewed-on: https://go-review.googlesource.com/123776
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/130795 mentions this issue: html: handle end-of-file cases correctly

gopherbot pushed a commit to golang/net that referenced this issue Aug 24, 2018
@namusyaka @nigeltao
html: handle end-of-file cases correctly
faa378e 
Updates golang/go#23071

Change-Id: I02a61109b5738759a9ee3e448981778de7d0ff62
Reviewed-on: https://go-review.googlesource.com/130795
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/131178 mentions this issue: html: copy passed tests from webkit

gopherbot pushed a commit to golang/net that referenced this issue Aug 24, 2018
@namusyaka @bradfitz
html: copy passed tests from chromium
4bcd98c 
Updates golang/go#23071

Change-Id: I1fdf3fe8c94efdf3c4bf9c39900468381159a032
Reviewed-on: https://go-review.googlesource.com/131178
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/131475 mentions this issue: html: fix wrong comparison in foster parenting algorithm

@dmitshur dmitshur mentioned this issue Sep 17, 2018
Closed
@golang golang locked and limited conversation to collaborators Aug 26, 2019
tmm1 pushed a commit to fancybits/go-net that referenced this issue Sep 12, 2022
@namusyaka @tmm1
html: fix wrong comparison in foster parenting algorithm
22c8013 
Fixes golang/go#23071

Change-Id: I383e13bfd87e32ffb775dff54c46b66b090e5017
Reviewed-on: https://go-review.googlesource.com/131475
Run-TryBot: Kunpei Sakai <namusyaka@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Nigel Tao <nigeltao@golang.org>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
4 participants
@namusyaka @andybons @nigeltao @gopherbot