Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: signal stack change broke DragonflyBSD #23061

Closed
bradfitz opened this issue Dec 8, 2017 · 4 comments
Closed

runtime: signal stack change broke DragonflyBSD #23061

bradfitz opened this issue Dec 8, 2017 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.10

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Dec 8, 2017

This CL (292558b) broke Dragonfly:

runtime: restore the Go-allocated signal stack in unminit
https://go-review.googlesource.com/c/go/+/81476

I emailed Austin & Ian details of how to access a VM I created.
@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Dec 8, 2017
@bradfitz bradfitz added this to the Go1.10 milestone Dec 8, 2017
@bradfitz
Copy link
Contributor Author

bradfitz commented Dec 8, 2017

/cc @aclements @ianlancetaylor

@ianlancetaylor
Copy link
Contributor

This most likely has to do with the fact that on DragonFly a newly created thread inherits the alternate signal stack of the creating thread. See the comment in minit in runtime/os_dragonfly.go.

@ianlancetaylor
Copy link
Contributor

Sorry, I was looking at an old source tree due to a complex accident. DragonFly used to work that way, but it's been fixed.

@gopherbot
Copy link

Change https://golang.org/cl/83035 mentions this issue: runtime: don't use MAP_STACK on DragonFly in SigStack test

@golang golang locked and limited conversation to collaborators Dec 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
3 participants
@bradfitz @ianlancetaylor @gopherbot