Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/maintner: CLs that switch branches remain on the original branch #23007

Closed
bradfitz opened this issue Dec 5, 2017 · 6 comments
Closed

x/build/maintner: CLs that switch branches remain on the original branch #23007

bradfitz opened this issue Dec 5, 2017 · 6 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

bradfitz commented Dec 5, 2017

I've noticed that Trybots run on this CL forever:

https://go-review.googlesource.com/c/go/+/33776

It has Run-TryBot=+1 set on it, so every time the coordinator restarts, it starts a TryBot run for it.

Then the TryBots pass, and it tries to leave a vote on Gerrit that TryBot-Result=+1, but Gerrit says 404:

2017/12/05 05:24:29 Starting new trybot set for {go dev.tls I6052695ece9aff9e3112c2fb176596fde8aa9cb2 1df669af17dbeee3930828e0ba543582209a3a1b}
2017/12/05 05:24:29 Error getting Gerrit comments on go~dev.tls~I6052695ece9aff9e3112c2fb176596fde8aa9cb2: HTTP status 404 Not Found; Not found: go~dev.tls~I6052695ece9aff9e3112c2fb176596fde8aa9cb2

and

2017/12/05 05:33:03 Failed to call Gerrit: HTTP status 404 Not Found; Not found: go~dev.tls~I6052695ece9aff9e3112c2fb176596fde8aa9cb2

Therefore it hangs around at the top of the coordinator status page forever, since it thinks it needs to be done, but it already has one running, which has nothing to do:

screen shot 2017-12-05 at 3 29 48 pm

I imagine the period in the branch name is bogus and confusing Gerrit?

@andybons, do you know?

From https://gerrit-review.googlesource.com/Documentation/rest-api-changes.html#change-id I see nothing special about <branch> escaping, but maybe I'm missing something.
@gopherbot gopherbot added this to the Unreleased milestone Dec 5, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Dec 5, 2017
@andybons
Copy link
Member

andybons commented Dec 6, 2017

That change's ID is go~master~I6052695ece9aff9e3112c2fb176596fde8aa9cb2 since it's on the master branch.

dev.tls doesn't seem to be messing up in the API endpoints. curl https://go-review.googlesource.com/changes/go~dev.tls~Ia1b06ae518a4b2821a584a420d99859a2666c8f0/detail does just fine.

@bradfitz
Copy link
Contributor Author

bradfitz commented Dec 6, 2017

Oh, weird. So why is the coordinator getting confused and thinking it's dev.tls?

@andybons
Copy link
Member

andybons commented Dec 6, 2017

Good question. Let me take a quick look...

@andybons
Copy link
Member

andybons commented Dec 6, 2017

The maintner corpus thinks that it’s in the refs/heads/dev.tls branch. My guess is that when Filippo switched from dev.tls to master (https://go-review.googlesource.com/c/go/+/33776#message-60a9b48d3094de83bdcf1b5f838ef2c323d56603) that it didn’t take the switch into account.

@bradfitz
Copy link
Contributor Author

bradfitz commented Dec 6, 2017

Ah, okay. Thanks. I'll look into a fix.

@andybons andybons changed the title x/build/cmd/coordinator: trybot never marks itself done on dev.tls branch CL x/build/maintner: CLs that switch branches remain on the original branch Dec 6, 2017
@gopherbot
Copy link

Change https://golang.org/cl/83635 mentions this issue: maintner: account for CLs changing branches

@golang golang locked and limited conversation to collaborators Dec 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @andybons @gopherbot