Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/compile: wrong evaluation order for map assignment [Go1.9] #23005

Closed
randall77 opened this issue Dec 5, 2017 · 6 comments
Closed

cmd/compile: wrong evaluation order for map assignment [Go1.9] #23005

randall77 opened this issue Dec 5, 2017 · 6 comments

Comments

@randall77
Copy link
Contributor

Go 1.9.3 issue for #22881.

@randall77 randall77 added this to the Go1.9.3 milestone Dec 5, 2017
@JicLotus
Copy link

Can I take it?

@odeke-em
Copy link
Member

Thank you @JicLotus for the offer, but this issue was already fixed by CL https://go-review.googlesource.com/81817 aka commit dd7cbf3. @randall77 opened this issue as a placeholder for a backport to Go1.9, when Go1.9.3 is being released.

If you'd like to work on some compiler issues there are very many interesting ones https://github.com/golang/go/issues?utf8=%E2%9C%93&q=is%3Aissue+is%3Aopen+cmd%2Fcompile+in%3Atitle
or even generally all other issues, you are welcome to check out any, and thank you.

@JicLotus
Copy link

Many Thanks @odeke-em

@ianlancetaylor
Copy link
Contributor

My opinion is that we should not fix this issue for 1.9.3 (or 1.8.6). It may in some rare cases change the behavior of existing programs (and if it does not change the behavior, it won't do anything). The behavior is a correct fix for the language, but it seems to me unlikely to actually fix a program that is currently working. I think it's better to reserve this kind of change for 1.10 rather than run the risk of breaking programs in a minor release.

To put it another way: chance of breaking a program with 1.9.3: low. Chance of fixing a program with 1.9.3: lower. So, don't backport.

@randall77
Copy link
Contributor Author

There is the case of future programs being written under 1.9, which would benefit from this bug being fixed.

But with that caveat, I still agree with Ian, probably not worth backporting.
The workaround for this issue is easy.

@ianlancetaylor
Copy link
Contributor

Thanks, closing.

@andybons andybons removed this from the Go1.9.3 milestone Jan 18, 2018
@golang golang locked and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants