Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

runtime: unsafe pointer maps #22931

Open
RLH opened this issue Nov 29, 2017 · 3 comments
Open

runtime: unsafe pointer maps #22931

RLH opened this issue Nov 29, 2017 · 3 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@RLH
Copy link
Contributor

RLH commented Nov 29, 2017 •
edited

There are several places in the code where pointers are stored into slots that the pointer maps do not note as holding pointers.

While the occurrences found so far appear benign with the current GC they do prevent adding diagnostics to the write barrier intended to detect errant writes. At the very least they should be documented as to why they are benign.
@robpike
Copy link
Contributor

robpike commented Nov 30, 2017

It would be nice to list those locations here.

@RLH
Copy link
Contributor Author

RLH commented Nov 30, 2017 via email

@ianlancetaylor ianlancetaylor added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Mar 29, 2018
@ianlancetaylor ianlancetaylor added this to the Go1.11 milestone Mar 29, 2018
@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jul 10, 2018
@odeke-em
Copy link
Member

odeke-em commented Feb 4, 2019

Great, thank you @RLH for the report and for the initial CL to get things rolling!

I am going to also kindly page @josharian @randall77 @mknyszek @aclements who might
all be interested in this issue and then punt this issue to Go1.13.

@odeke-em odeke-em modified the milestones: Go1.12, Go1.13 Feb 4, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@rsc rsc unassigned RLH Jun 23, 2022
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Compiler / Runtime
Status: Triage Backlog
Milestone
Backlog
Development

No branches or pull requests
7 participants
@rsc @andybons @RLH @ianlancetaylor @robpike @odeke-em @gopherbot