Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: unnecessary error after "cannot refer to unexported type" #22921

Closed
mvdan opened this issue Nov 29, 2017 · 4 comments
Closed

cmd/compile: unnecessary error after "cannot refer to unexported type" #22921

mvdan opened this issue Nov 29, 2017 · 4 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Backlog

Comments

@mvdan
Copy link
Member

mvdan commented Nov 29, 2017

https://play.golang.org/p/ZwFSxT9JCu

Output on both 1.9.2 and tip:

tmp/sandbox627872070/main.go:6:8: cannot refer to unexported name bytes.buffer
tmp/sandbox627872070/main.go:6:8: undefined: bytes.buffer

Is the second error really necessary? It seems redundant to me, unless there is a good reason for it to be there.

/cc @mdempsky @griesemer
@bradfitz bradfitz added this to the Go1.11 milestone Nov 29, 2017
@bradfitz bradfitz added the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Nov 29, 2017
@griesemer griesemer added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 29, 2017
@gopherbot gopherbot removed the NeedsDecision Feedback is required from experts, contributors, and/or the community before a change can be made. label Nov 29, 2017
@griesemer
Copy link
Contributor

There's no need for two errors.

@griesemer griesemer modified the milestones: Go1.11, Go1.12 Jun 27, 2018
@mvdan
Copy link
Member Author

mvdan commented Nov 28, 2018

Doesn't seem important enough to keep around for 1.12. Also, should @mdempsky still be assigned?

@mvdan mvdan modified the milestones: Go1.12, Go1.13 Nov 28, 2018
@mdempsky mdempsky removed their assignment Nov 28, 2018
@griesemer griesemer self-assigned this Nov 28, 2018
@griesemer griesemer modified the milestones: Go1.13, Go1.14 May 6, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@ALTree ALTree mentioned this issue Jan 6, 2020
Closed
@ALTree
Copy link
Member

ALTree commented Jan 6, 2020

Note: #36410 was recently opened reporting the same issue, and it was milestoned as 1.15.

@griesemer griesemer modified the milestones: Backlog, Go1.15 Jan 6, 2020
@ianlancetaylor ianlancetaylor modified the milestones: Go1.15, Backlog May 19, 2020
@gopherbot
Copy link

Change https://golang.org/cl/250177 mentions this issue: cmd/compile: report error for unexported name one time only

@golang golang locked and limited conversation to collaborators Aug 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
8 participants
@bradfitz @mdempsky @rsc @ianlancetaylor @mvdan @ALTree @griesemer @gopherbot