Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile: exit compilation earlier if type checking fails #22909

Closed
mdempsky opened this issue Nov 28, 2017 · 2 comments
Closed

cmd/compile: exit compilation earlier if type checking fails #22909

mdempsky opened this issue Nov 28, 2017 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Milestone
Go1.11

Comments

@mdempsky
Copy link
Member

mdempsky commented Nov 28, 2017 •
edited

Issues like #22904 happen because the backend doesn't expect to deal with invalid code. Instead of having to kludge checks everywhere, we should just exit compilation at the end of type checking if we found any errors. (Analogously, we already exit after parsing if there are syntax errors.)

/cc @griesemer
@mdempsky mdempsky added this to the Go1.11 milestone Nov 28, 2017
@mdempsky mdempsky mentioned this issue Nov 28, 2017
Closed
@griesemer
Copy link
Contributor

This should be easy to do and increase compiler stability. Marking release blocker.

@griesemer griesemer self-assigned this Jun 5, 2018
@griesemer griesemer added NeedsFix The path to resolution is known, but the work has not been done. release-blocker labels Jun 5, 2018
@gopherbot
Copy link

Change https://golang.org/cl/116335 mentions this issue: cmd/compile: terminate compilation if type-checking fails

@golang golang locked and limited conversation to collaborators Jun 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. release-blocker
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
3 participants
@mdempsky @griesemer @gopherbot