Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/godoc: tests broken on Go 1.8 #22897

Closed
bradfitz opened this issue Nov 28, 2017 · 7 comments
Closed

x/tools/cmd/godoc: tests broken on Go 1.8 #22897

bradfitz opened this issue Nov 28, 2017 · 7 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone
Go1.10

Comments

@bradfitz
Copy link
Contributor

The x/tools repo is red across all operating systems for Go 1.8. See https://build.golang.org/

Example failure:

https://build.golang.org/log/8bd4463805a63aa18a9981efcb5258969ec6cca1

?   	golang.org/x/tools/cmd/eg	[no test files]
ok  	golang.org/x/tools/cmd/fiximports	2.226s
ok  	golang.org/x/tools/cmd/getgo	0.010s
?   	golang.org/x/tools/cmd/getgo/server	[no test files]
ok  	golang.org/x/tools/cmd/go-contrib-init	0.005s
?   	golang.org/x/tools/cmd/godex	[no test files]
2017/11/24 16:27:41 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:41 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:41 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:42 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:42 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:42 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:42 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:42 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:43 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:43 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:43 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:43 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:44 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:44 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:44 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:44 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:44 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:45 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:45 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:45 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:45 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:46 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:46 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:46 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:46 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:46 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:47 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:47 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:47 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:47 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:47 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:48 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:48 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:48 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:48 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:49 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:49 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:49 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:49 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:49 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:50 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:50 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:50 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:50 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:50 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:51 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:51 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:51 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:51 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:52 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:52 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:52 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:52 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:52 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:53 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:53 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:53 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:53 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:53 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:54 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:54 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:54 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:54 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:55 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:55 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:55 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:55 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:55 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
2017/11/24 16:27:56 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page
--- FAIL: TestWeb (22.23s)
	godoc_test.go:185: Server failed to respond in 15s
2017/11/24 16:28:06 updateMetadata: open /tmp/godoc-analysis044698526/goroot/doc: no such file or directory
2017/11/24 16:28:06 GOROOT=/tmp/godoc-analysis044698526/goroot/src/: [lib]
2017/11/24 16:28:06 GOPATH[0]=/tmp/godoc-analysis044698526/gopath/src/: [app]
2017/11/24 16:28:06 Loading and type-checking packages...
2017/11/24 16:28:06 updateMetadata: open /tmp/godoc-analysis044698526/goroot/doc: no such file or directory
2017/11/24 16:28:06 Loaded 2 packages.
2017/11/24 16:28:06 Constructing SSA form...
2017/11/24 16:28:06 SSA construction complete
2017/11/24 16:28:06 Computing implements relation...
2017/11/24 16:28:06 Extracting type info...
2017/11/24 16:28:06 Visit instructions...
2017/11/24 16:28:06 Visit instructions complete
2017/11/24 16:28:06 Type analysis complete.
FAIL
FAIL	golang.org/x/tools/cmd/godoc	41.586s
?   	golang.org/x/tools/cmd/goimports	[no test files]
?   	golang.org/x/tools/cmd/gomvpkg	[no test files]
ok  	golang.org/x/tools/cmd/gorename	10.562s
?   	golang.org/x/tools/cmd/gotype	[no test files]
?   	golang.org/x/tools/cmd/goyacc	[no test files]
@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. labels Nov 28, 2017
@bradfitz bradfitz added this to the Unreleased milestone Nov 28, 2017
@bradfitz bradfitz assigned alandonovan and andybons and unassigned alandonovan Nov 28, 2017
@bradfitz
Copy link
Contributor Author

@andybons, I think this is actually yours. It seems related to the GoogleCN stuff.

All the repeated lines saying 2017/11/24 16:27:41 executing template doc/root.html: template: main:26:6: executing "main" at <$.Share>: can't evaluate field Share in type godoc.Page are just the every-200ms for 15 seconds health checks against the localhost godoc server.

But the localhost godoc server for Go 1.8 is returning a text/template error about a bogus field.

I'm not sure where that is, though.

Can you look into it? This is the last red on build.golang.org and I want to enable past releases on trybots for subrepos.

@bradfitz bradfitz modified the milestones: Unreleased, Go1.10 Nov 29, 2017
@andybons
Copy link
Member

Will take a look now...

@andybons
Copy link
Member

Builders seem to be OK on 1.8 after cherry-picking

@bradfitz bradfitz reopened this Dec 7, 2017
@bradfitz
Copy link
Contributor Author

bradfitz commented Dec 7, 2017

And now it's broken for Go 1.9 and tip, but works at Go 1.8.

Andy, back to you.

For testing multiple Go versions, the go command in my $PATH is:

$ cat ~/bin/go
#!/bin/sh

exec $GOROOT/bin/go "$@"

And then I set GOROOT to one of three environments when I run "go test" places.

@andybons
Copy link
Member

andybons commented Dec 7, 2017

Cool. Thanks for the tip. Will look into it.

@andybons
Copy link
Member

andybons commented Dec 7, 2017

I don’t see any failures on build.golang.org for tools and I can’t repro locally on tip, at least. Can you point me to an example of the breakage?

@bradfitz
Copy link
Contributor Author

bradfitz commented Dec 7, 2017

Weird. They were all red last night, and you can still see it in the hitsory at:

https://build.golang.org/?repo=golang.org%2fx%2ftools

I think the App Engine app (which decides what needs to be built, not from maintner) might be drunk and confused by branches somehow.

I guess we can close this, but some problem remains in build.golang.org deciding what to build on what branches.

@bradfitz bradfitz closed this as completed Dec 7, 2017
@golang golang locked and limited conversation to collaborators Dec 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
4 participants
@bradfitz @andybons @alandonovan @gopherbot