-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: FreeBSD images don't shut down nicely #22895
Labels
Milestone
Comments
Change https://golang.org/cl/80335 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Nov 28, 2017
Use /boot/loader.conf from the official FreeBSD GCE image. Add /sbin to the PATH environment variable buildlet is running with, so that poweroff and shutdown are found. Fixes golang/go#22894 Updates golang/go#22895 Change-Id: I2f8b56ff7df4726e4f8ef72357934f2f7abb8e59 Reviewed-on: https://go-review.googlesource.com/80335 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Change https://golang.org/cl/80304 mentions this issue: |
gopherbot
pushed a commit
to golang/build
that referenced
this issue
Nov 28, 2017
FreeBSD VMs boot up 10 seconds faster now, and shut down faster. Updates golang/go#22894 Updates golang/go#22895 Change-Id: I8eef979fc43d95d3c03104a761e70ec5737a3a97 Reviewed-on: https://go-review.googlesource.com/80304 Reviewed-by: Andrew Bonventre <andybons@golang.org>
Change https://golang.org/cl/82896 mentions this issue: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
I noticed while testing my images for #19303 and #22854 that our FreeBSD images (at least 10.3) don't have shutdown in their path:
The cmd/buildlet code is trying to do:
Maybe it needs an explicit path.
/cc @paulzhol
The text was updated successfully, but these errors were encountered: