-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: optimize FreeBSD image boot time #22894
Comments
The images need to have |
Thanks! |
Change https://golang.org/cl/80335 mentions this issue: |
While running make.bash with this latest code on 11.1, I noticed a kernel crash:
And then it rebooted:
Fun. Want to file an upstream FreeBSD kernel bug? |
yikes! does it reproduce? You're running this inside a GCE linux VM right? (When I tried locally I flipped the |
Yes, I'm in a GCE Debian Jessie VM, running your make.bash unmodified. (so qemu with whatever options you specified) I've seen it twice now: in both 11.1, and 10.3. I'm in a GNU Screen session, if that matters, and both times I saw it happened might've been while I was flipping between virtual terminals. (Does screen send some signal or keypess when I do that which is confusing qemu?) |
But I just re-ran So it's not 100% of the time. |
with But this
came from a regular |
Change https://golang.org/cl/80304 mentions this issue: |
FreeBSD VMs boot up 10 seconds faster now, and shut down faster. Updates golang/go#22894 Updates golang/go#22895 Change-Id: I8eef979fc43d95d3c03104a761e70ec5737a3a97 Reviewed-on: https://go-review.googlesource.com/80304 Reviewed-by: Andrew Bonventre <andybons@golang.org>
@bradfitz does adding diff --git a/env/freebsd-amd64/make.bash b/env/freebsd-amd64/make.bash
index 0df60bd..201d3bc 100755
--- a/env/freebsd-amd64/make.bash
+++ b/env/freebsd-amd64/make.bash
@@ -148,7 +148,7 @@ sleep 2
# TODO(wathiede): set serial output so we can track boot on GCE.
expect <<EOF
set timeout 600
-spawn qemu-system-x86_64 -display curses -smp 2 -drive if=virtio,file=disk.raw,cache=none -cdrom config.iso -net nic,model=virtio -net user
+spawn qemu-system-x86_64 -display curses -smp 2 -m 1G -drive if=virtio,file=disk.raw,cache=none -cdrom config.iso -net nic,model=virtio -net user
# Speed-up boot by going in to single user mode.
expect "Welcome to FreeBSD" |
I can try that next time I update the FreeBSD images, but now I have to update some other operating systems. |
I noticed while testing my images for #19303 and #22854 that our FreeBSD images have a 10 second boot prompt countdown. (I watched it count down with cute art on "serial" over the remote serial API)
Let's remove that 10 second countdown and get FreeBSD booting faster. 10 seconds is a notable percentage of the time our VMs live.
/cc @paulzhol
The text was updated successfully, but these errors were encountered: