Skip to content

cmd/go: re-enable go/types requirement during vet during go test #22890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rsc opened this issue Nov 27, 2017 · 6 comments
Closed

cmd/go: re-enable go/types requirement during vet during go test #22890

rsc opened this issue Nov 27, 2017 · 6 comments
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge
Milestone
Go1.11

Comments

@rsc
Copy link
Contributor

rsc commented Nov 27, 2017

@griesemer has some reports that go/types fails on some code during automatic vet-during-test. We should make a type-checking failure during vet-during-go-test a silent vet success instead (we know the code compiles, so we know vet is at fault), but vet-during-go-vet should still fail.
@rsc rsc added this to the Go1.10 milestone Nov 27, 2017
@griesemer
Copy link
Contributor

For the reference: The offending go/types issue is #18395 (plus a few duplicates).

@griesemer griesemer mentioned this issue Nov 27, 2017
Closed
@mvdan
Copy link
Member

mvdan commented Nov 27, 2017

Should a warning of some sort be printed? Otherwise, the user might get the wrong idea that there are no vet warnings at all.

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/81500 mentions this issue: cmd/go: ignore vet typecheck failure during go test

gopherbot pushed a commit that referenced this issue Dec 1, 2017
@rsc
cmd/go: ignore vet typecheck failure during go test
76dc4b1 
For Go 1.10, works around a go/types bug that can't typecheck
a corner-case type cycle. Once we are confident that bugs like
this are gone from go/types then we can stop ignoring these
failures.

For #22890.

Change-Id: I38da57e01a0636323e1af4484c30871786125df3
Reviewed-on: https://go-review.googlesource.com/81500
Run-TryBot: Russ Cox <rsc@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
@rsc
Copy link
Contributor Author

rsc commented Dec 4, 2017

The CL is in, so vet no longer dies. Repurposing this issue for removing the check once we believe go/types is safe to require (hopefully for Go 1.11).

@rsc rsc modified the milestones: Go1.10, Go1.11 Dec 4, 2017
@rsc rsc added early-in-cycle A change that should be done early in the 3 month dev cycle. and removed release-blocker labels Dec 4, 2017
@rsc rsc changed the title cmd/go: vet during test should not die on invalid type check cmd/go: re-enable go/types requirement during vet during go test Dec 4, 2017
@mvdan
Copy link
Member

mvdan commented May 4, 2018

This is marked as early-in-cicle for 1.11 - do we still want to do this in the current cycle?

@ianlancetaylor
Copy link
Member

This was done by https://golang.org/cl/108555, so closing.

@griesemer griesemer mentioned this issue Aug 7, 2018
Closed
@golang golang locked and limited conversation to collaborators May 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
early-in-cycle A change that should be done early in the 3 month dev cycle. FrozenDueToAge
Projects
None yet
Milestone
Go1.11
Development

No branches or pull requests
5 participants
@rsc @ianlancetaylor @mvdan @griesemer @gopherbot