cmd/vet: know what builtin functions have no side effects #22851
Labels
Analysis
Issues related to static analysis (vet, x/tools/go/analysis)
help wanted
NeedsFix
The path to resolution is known, but the work has not been done.
Milestone
Reminder issue to continue the work in https://go-review.googlesource.com/c/go/+/79536.
For example,
len
andcap
never have any side effects, and it would be useful to know thati == len(x) || i == len(x)
is a suspicious expression.More broadly, this could be extended to automatically detect what functions are free of side effects. But this would require having access to the full source with full type information, and may be complex and costly, so I'm not entirely sure it's a right fit for vet.
A simpler version of the above would be to also add standard library functions, such as
strings.Contains
orpath.Join
. I don't know if it is OK for vet to treat standard library packages differently, though.The text was updated successfully, but these errors were encountered: