Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build: solaris-amd64-smartosbuildlets out of disk space from /tmp filling up #22798

Closed
bradfitz opened this issue Nov 18, 2017 · 2 comments
Closed

x/build: solaris-amd64-smartosbuildlets out of disk space from /tmp filling up #22798

bradfitz opened this issue Nov 18, 2017 · 2 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

The solaris-amd64-smartosbuildlet builders just run the reverse buildlet in a loop, reusing the same container for multiple builds. (It's kinda trashy, but we don't have somebody who's good at Joyent+Solaris to help do things properly.)

Anyway, because we're reusing the same environment per build, we run the risk of filesystem pollution, and we indeed have: we've filled /tmp after many months.

The buildlet could at least wipe+create its own temp directory on process start (say, /tmp/buildlettmp) and set TMPDIR to it, so cmd/go and various tests use it by default. Should work. Still not ideal, but better.
@bradfitz bradfitz added NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris labels Nov 18, 2017
@bradfitz bradfitz self-assigned this Nov 18, 2017
@gopherbot gopherbot added this to the Unreleased milestone Nov 18, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 18, 2017
@bradfitz
Copy link
Contributor Author

Also should add the Solaris spelling of "out of disk space" to x/build/cmd/retrybuilds. The case differs from Linux etc.

@gopherbot
Copy link

Change https://golang.org/cl/79137 mentions this issue: cmd/buildlet: make fresh TMPDIR and clean it on Joyent Solaris builders

@golang golang locked and limited conversation to collaborators Nov 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done. OS-Solaris
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@bradfitz @gopherbot