Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: trybots are missing in action #22763

Closed
rsc opened this issue Nov 16, 2017 · 4 comments
Closed

build: trybots are missing in action #22763

rsc opened this issue Nov 16, 2017 · 4 comments

Comments

@rsc
Copy link
Contributor

rsc commented Nov 16, 2017

https://go-review.googlesource.com/c/go/+/78195 has a Run-TryBot +1 from 10:08 AM.
https://go-review.googlesource.com/c/go/+/78115/5 has one from 10:04 AM.
https://go-review.googlesource.com/c/go/+/78113/6 also has one from 10:04 AM.

No word from the farmer on any of these. The front page on the farmer does not mention them. Maybe whatever watches Gerrit has fallen over?

(And it's now 10:58 AM here.)

/cc @bradfitz

@bradfitz
Copy link
Contributor

I'm having Internet connectivity issues this morning and then traveling back home, so sadly I won't get to investigate this for a bit.

I'll fix it, though.

@bradfitz bradfitz self-assigned this Nov 16, 2017
@rsc
Copy link
Contributor Author

rsc commented Nov 16, 2017

Congratulations / condolences on building a piece of infrastructure that has become so essential. I really feel like I'm working in the past today.

@gopherbot
Copy link

Change https://golang.org/cl/78536 mentions this issue: maintner: fix label counting, which affected trybot work-to-do caching

@gopherbot
Copy link

Change https://golang.org/cl/78540 mentions this issue: maintner: add a missing finishProcessing call

gopherbot pushed a commit to golang/build that referenced this issue Nov 17, 2017
We also need to call finishProcessing (added in golang.org/cl/77690) to whenever
we append to the mutation log.

Otherwise we never finish building data structures needed when
maintner is used in mutation-generation & API server mode.

Fixes golang/go#22763 again.

Change-Id: I55270cd43f03bee0524df188c589ac01ab8fafda
Reviewed-on: https://go-review.googlesource.com/78540
Reviewed-by: Andrew Bonventre <andybons@golang.org>
@golang golang locked and limited conversation to collaborators Nov 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants