Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal/cpu: fix CRC32 on darwin/arm64 #22720

Closed
bradfitz opened this issue Nov 14, 2017 · 2 comments
Closed

internal/cpu: fix CRC32 on darwin/arm64 #22720

bradfitz opened this issue Nov 14, 2017 · 2 comments
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone

Comments

@bradfitz
Copy link
Contributor

I suspect the https://go-review.googlesource.com/c/go/+/76490 I'm about to submit might break CRC32 detection on darwin/arm64.

It used to use runtime.supportsCRC32() but will now use Linux-provided info. Since Darwin doesn't provide it, we should make sure we still populate ARM64.CRC32 on Darwin.

/cc @zhangfannie @eliasnaur

@bradfitz bradfitz added mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Nov 14, 2017
@bradfitz bradfitz added this to the Go1.10 milestone Nov 14, 2017
@eliasnaur
Copy link
Contributor

AFAICT, supportsCRC32 was never set and thus always false on darwin/arm64:

https://go-review.googlesource.com/c/go/+/76490/3/src/runtime/os_darwin_arm64.go#b7

So I don't think 76490 made it worse.

@bradfitz
Copy link
Contributor Author

@eliasnaur, ah, thanks! I'll close this then.

@golang golang locked and limited conversation to collaborators Nov 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge mobile Android, iOS, and x/mobile NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Development

No branches or pull requests

3 participants