Skip to content

cmd/test2json: clarify usage instructions #22710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
cespare opened this issue Nov 14, 2017 · 1 comment
Closed

cmd/test2json: clarify usage instructions #22710

cespare opened this issue Nov 14, 2017 · 1 comment
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge release-blocker
Milestone
Go1.10

Comments

@cespare
Copy link
Contributor

cespare commented Nov 14, 2017

(Copied from a comment I left on https://golang.org/cl/76872 after it was merged.)

I tried using the new test2json tool and found it initially confusing. Here it says

// Usage:
//
//	go test ... | go tool test2json [-p pkg] [-t]
//	./test.out 2>&1 | go tool test2json [-p pkg] [-t]

Should that recommend go test -v? Without -v, it says the test failed even when it passed:

$ go test strings | go tool test2json
{"Action":"output","Output":"ok  \tstrings\t(cached)\n"}
{"Action":"fail"}

cc @rsc
@cespare cespare added the Documentation Issues describing a change to documentation. label Nov 14, 2017
@cespare cespare added this to the Go1.10 milestone Nov 14, 2017
@gopherbot
Copy link
Contributor

Change https://golang.org/cl/81555 mentions this issue: cmd/test2json: add ability to run test binary

@golang golang locked and limited conversation to collaborators Dec 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Documentation Issues describing a change to documentation. FrozenDueToAge release-blocker
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
3 participants
@cespare @ianlancetaylor @gopherbot