We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please answer these questions before submitting your issue. Thanks!
go version
go version go1.9.2 darwin/amd64
Issue uncovered by inspection.
go env
Go playground using GOOS=nacl
Per comments at the head of fs_nacl.go:
// Since there is no I/O (everything is in memory), // the global lock mu protects the whole file system state, // and that's okay.
and
// Except where indicated otherwise, unexported methods on fsys // expect fs.mu to have been locked by the caller.
but Link and Rename call these methods without locking fs.
fs calls should be serialized
These two are not. Fix is trivial. I'm happy the needed changes
The text was updated successfully, but these errors were encountered:
Fine for Go 1.10, or whenever. Thanks.
Sorry, something went wrong.
Change https://golang.org/cl/79295 mentions this issue: syscall: add missing fs locking in Link, Rename
syscall: add missing fs locking in Link, Rename
a2a1c17
No branches or pull requests
Please answer these questions before submitting your issue. Thanks!
What version of Go are you using (
go version
)?go version go1.9.2 darwin/amd64
Does this issue reproduce with the latest release?
Issue uncovered by inspection.
What operating system and processor architecture are you using (
go env
)?Go playground using GOOS=nacl
What did you do?
Per comments at the head of fs_nacl.go:
and
but Link and Rename call these methods without locking fs.
What did you expect to see?
fs calls should be serialized
What did you see instead?
These two are not.
Fix is trivial. I'm happy the needed changes
The text was updated successfully, but these errors were encountered: