-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/build: hide all-red builders #22689
Comments
I also expect they (spacemonkey builders) should be working. |
I've fixed the plan9-amd64 builder a while ago, so it should be fine. However, the plan9-arm builder is currently red because of an issue raised by TestHttpsInsecure after the update of the github.com/google/pprof/internal/driver package (issue #22691). |
I suspect noopt breakage is issue #22444.
…On Mon, Nov 13, 2017 at 8:46 AM, Brad Fitzpatrick ***@***.***> wrote:
Sounds good. But alpine and plan9-amd64 are the one two I'd expect to be
read.
spacemonkey shouldn't be broken?
/cc @0intro <https://github.com/0intro> @zeebo <https://github.com/zeebo>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#22689 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGkgIBmHUoGa7axIDQ2DE_gkSreSIt5pks5s2HJWgaJpZM4Qb6-m>
.
|
Change https://golang.org/cl/78575 mentions this issue: |
It's doing no good being red all the time, especially as nobody is working on it. Updates golang/go#22689 Updates golang/go#19938 Change-Id: Icb947878d85e920f24ea458eb0f319844ca5bd60 Reviewed-on: https://go-review.googlesource.com/78575 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
I've fixed all the red that shouldn't be red. The remaining red is real or has outstanding CLs waiting to be approved. Closing this in favor of the specific bugs. Now that I'm back full-time, I'll be watching build.golang.org as usual. |
The columns of red on the dashboard should be fixed or removed from the default display. As things are now, the fact that we apparently expect some builders to be all red hides the fact that we don't expect other builders to be all red.
Right now, linux-amd64-alpine, linux-amd64-noopt, and linux-arm-arm5spacemonkey are all red. Apparently alpine and monkey are expected to be that way - there are long-term bugs open for fixing those - but noopt is not expected to be that. It looks like I broke noopt in CL 74470, but I didn't notice because it just added one more all-red column to the dashboard.
We should make it the case that all-red is always something that needs attention now, not a "would be nice" for the future.
/cc @bradfitz
The text was updated successfully, but these errors were encountered: