Sure, go ahead.

CL welcome for Go 1.11.

@rsc note that using stringer (the tool) in regexp/syntax might be problematic - was doing something similar in https://go-review.googlesource.com/c/go/+/77253.

What would the best solution here be? Not using the tool, making the package depend on fmt (likely not), or making stringer use strconv instead of fmt?

@mvdan

making the package depend on fmt (likely not), or making stringer use strconv instead of fmt?

Since Op is just uint8, it can be converted to a string without either fmt or strconv (and without allocations, too):
https://play.golang.org/p/iDrD8ecBjO

@opennota I think it is overkill for either regexp/syntax or stringer to worry about such micro-optimizations. Even better, strconv already does this for you - see the small stuff in https://golang.org/src/strconv/itoa.go?s=764:804#L13.

I changed stringer to use strconv earlier this week, so this change will be trivial to do in 1.11. I'll be doing other stringer improvements (like the already mailed https://go-review.googlesource.com/c/go/+/77253), so I can take this if you'd like.

@mvdan

I can take this if you'd like

By all means.

Change https://golang.org/cl/95355 mentions this issue: regexp/syntax: make Op an fmt.Stringer