Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: TestGoTestJSON failing on Plan 9, DragonFly BSD and Solaris #22665

Closed
0intro opened this issue Nov 10, 2017 · 10 comments
Closed

cmd/go: TestGoTestJSON failing on Plan 9, DragonFly BSD and Solaris #22665

0intro opened this issue Nov 10, 2017 · 10 comments
Labels
FrozenDueToAge OS-Dragonfly OS-NetBSD OS-Plan9 OS-Solaris
Milestone
Go1.10

Comments

@0intro
Copy link
Member

0intro commented Nov 10, 2017 •
edited

CL 76873 added TestGoTestJSON. This test is failing on Plan 9, DragonFly BSD and Solaris.

--- FAIL: TestGoTestJSON (5.27s)
	go_test.go:5088: running testgo [test -json -short -v sleepy1 sleepy2]
	go_test.go:5088: standard output:
	go_test.go:5088: {"Time":"2017-11-10T14:07:26.035849323-05:00","Action":"run","Package":"sleepy1","Test":"Test1"}
		{"Time":"2017-11-10T14:07:26.037243908-05:00","Action":"output","Package":"sleepy1","Test":"Test1","Output":"=== RUN   Test1\n"}
		{"Time":"2017-11-10T14:07:26.246511787-05:00","Action":"output","Package":"sleepy1","Test":"Test1","Output":"--- PASS: Test1 (0.21s)\n"}
		{"Time":"2017-11-10T14:07:26.246597273-05:00","Action":"pass","Package":"sleepy1","Test":"Test1","Elapsed":0.21}
		{"Time":"2017-11-10T14:07:26.246789196-05:00","Action":"output","Package":"sleepy1","Output":"PASS\n"}
		{"Time":"2017-11-10T14:07:26.247186451-05:00","Action":"output","Package":"sleepy1","Output":"ok  \tsleepy1\t0.233s\n"}
		{"Time":"2017-11-10T14:07:26.247250146-05:00","Action":"pass","Package":"sleepy1","Elapsed":0.233}
		{"Time":"2017-11-10T14:07:26.877004862-05:00","Action":"run","Package":"sleepy2","Test":"Test1"}
		{"Time":"2017-11-10T14:07:26.877110462-05:00","Action":"output","Package":"sleepy2","Test":"Test1","Output":"=== RUN   Test1\n"}
		{"Time":"2017-11-10T14:07:27.086531712-05:00","Action":"output","Package":"sleepy2","Test":"Test1","Output":"--- PASS: Test1 (0.21s)\n"}
		{"Time":"2017-11-10T14:07:27.08660295-05:00","Action":"pass","Package":"sleepy2","Test":"Test1","Elapsed":0.21}
		{"Time":"2017-11-10T14:07:27.08665994-05:00","Action":"output","Package":"sleepy2","Output":"PASS\n"}
		{"Time":"2017-11-10T14:07:27.087113348-05:00","Action":"output","Package":"sleepy2","Output":"ok  \tsleepy2\t0.231s\n"}
		{"Time":"2017-11-10T14:07:27.087177881-05:00","Action":"pass","Package":"sleepy2","Elapsed":0.232}
		
	go_test.go:5088: running testgo [test -json -short -v sleepy1 sleepy2]
	go_test.go:5088: standard output:
	go_test.go:5088: {"Time":"2017-11-10T14:07:28.503063301-05:00","Action":"run","Package":"sleepy1","Test":"Test1"}
		{"Time":"2017-11-10T14:07:28.503983526-05:00","Action":"output","Package":"sleepy1","Test":"Test1","Output":"=== RUN   Test1\n"}
		{"Time":"2017-11-10T14:07:28.70668328-05:00","Action":"output","Package":"sleepy1","Test":"Test1","Output":"--- PASS: Test1 (0.20s)\n"}
		{"Time":"2017-11-10T14:07:28.706766251-05:00","Action":"pass","Package":"sleepy1","Test":"Test1","Elapsed":0.2}
		{"Time":"2017-11-10T14:07:28.706829946-05:00","Action":"output","Package":"sleepy1","Output":"PASS\n"}
		{"Time":"2017-11-10T14:07:28.707235582-05:00","Action":"output","Package":"sleepy1","Output":"ok  \tsleepy1\t0.228s\n"}
		{"Time":"2017-11-10T14:07:28.707303468-05:00","Action":"pass","Package":"sleepy1","Elapsed":0.228}
		{"Time":"2017-11-10T14:07:29.210961306-05:00","Action":"run","Package":"sleepy2","Test":"Test1"}
		{"Time":"2017-11-10T14:07:29.211088696-05:00","Action":"output","Package":"sleepy2","Test":"Test1","Output":"=== RUN   Test1\n"}
		{"Time":"2017-11-10T14:07:29.416782952-05:00","Action":"output","Package":"sleepy2","Test":"Test1","Output":"--- PASS: Test1 (0.21s)\n"}
		{"Time":"2017-11-10T14:07:29.416905314-05:00","Action":"pass","Package":"sleepy2","Test":"Test1","Elapsed":0.21}
		{"Time":"2017-11-10T14:07:29.416950571-05:00","Action":"output","Package":"sleepy2","Output":"PASS\n"}
		{"Time":"2017-11-10T14:07:29.417348664-05:00","Action":"output","Package":"sleepy2","Output":"ok  \tsleepy2\t0.230s\n"}
		{"Time":"2017-11-10T14:07:29.417411521-05:00","Action":"pass","Package":"sleepy2","Elapsed":0.23}
		
	go_test.go:5106: did not find fmt interlaced with math
FAIL
FAIL	cmd/go	271.191s

See https://build.golang.org/log/16d3232d3e0ff30e3239e6a139f65267b9f2bab2

@rsc
@0intro 0intro added this to the Go1.10 milestone Nov 10, 2017
@0intro 0intro self-assigned this Nov 10, 2017
@0intro
Copy link
Member Author

0intro commented Nov 10, 2017 •
edited

This test seems to succeed only on SMP machines.

@ALTree
Copy link
Member

ALTree commented Nov 10, 2017

I see linux/386 failures, too

https://build.golang.org/log/b6647d0a867799ff03d09540c1f1e6c40940815a

and here on linux/amd64:

https://build.golang.org/log/43557fbe0bd51a2e49a16899b26bde30fc791aa1

I think it's just flaky.

@0intro
Copy link
Member Author

0intro commented Nov 10, 2017

Yes, it's flaky, but it also never works on the plan9/386 builder which is uniprocessor.
I suspect that the dragonfly/amd64 builder is uniprocessor as well.

I reproduced the issue at home by running the test on the same Plan 9 machine with SMP enabled and SMP disabled: the test only works when SMP is enabled.

@gopherbot
Copy link

Change https://golang.org/cl/77130 mentions this issue: cmd/go: skip TestGoTestJSON on uniprocessor machines

@0intro
Copy link
Member Author

0intro commented Nov 10, 2017

The flakiness can probably be reduced by increasing the number of tries.

@ALTree
Copy link
Member

ALTree commented Nov 10, 2017

Ah, thanks. We'll need another issue to track the flakiness, then.

@0intro
Copy link
Member Author

0intro commented Nov 10, 2017

I think it should be fine to track it here.

@timdarbydotnet
Copy link

Yes, the Dragonfly builder happens to be uniprocessor.

@gopherbot
Copy link

Change https://golang.org/cl/77310 mentions this issue: cmd/go: deflake TestGoTestJSON further

@ianlancetaylor
Copy link
Contributor

Another failure in https://storage.googleapis.com/go-build-log/c325a08a/openbsd-amd64-60_d57a4740.log

@bradfitz bradfitz reopened this Nov 15, 2017
@bradfitz bradfitz mentioned this issue Nov 15, 2017
Closed
@golang golang locked and limited conversation to collaborators Nov 16, 2018
@rsc rsc unassigned 0intro Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge OS-Dragonfly OS-NetBSD OS-Plan9 OS-Solaris
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
6 participants
@bradfitz @ianlancetaylor @ALTree @0intro @gopherbot @timdarbydotnet