Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/devapp: reviews handler shows merged CLs #22653

Closed
bradfitz opened this issue Nov 10, 2017 · 4 comments
Closed

x/build/devapp: reviews handler shows merged CLs #22653

bradfitz opened this issue Nov 10, 2017 · 4 comments
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Milestone
Unreleased

Comments

@bradfitz
Copy link
Contributor

https://dev.golang.org/reviews currently shows:

2017-05-22  Gustav Westling   38634 encoding/base32: add Encoding.WithPadding, StdPadding, NoPadding

But https://go-review.googlesource.com/c/go/+/38634 is merged so it shouldn't be listed as a TODO item.
@gopherbot gopherbot added this to the Unreleased milestone Nov 10, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 10, 2017
@andybons
Copy link
Member

Something is up with maintner’s data, since I’m using ForeachOpenCL: https://go.googlesource.com/build/+/master/devapp/reviews.go#116

@bradfitz
Copy link
Contributor Author

Could you investigate? A good place to add tests (or just tests for debugging) is x/build/maintner/godata/godata_test.go, which works with the same live maintner data.

@bradfitz
Copy link
Contributor Author

Oh, this got tricksy. I'm on it.

@bradfitz bradfitz assigned bradfitz and unassigned andybons Nov 14, 2017
@gopherbot
Copy link

Change https://golang.org/cl/77690 mentions this issue: maintner: handle Gerrit ref meta changes occurring before dependent git commits

@golang golang locked and limited conversation to collaborators Nov 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@bradfitz @andybons @gopherbot