Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/pprof: tests start web browser #22651

Closed
rsc opened this issue Nov 10, 2017 · 1 comment
Closed

cmd/pprof: tests start web browser #22651

rsc opened this issue Nov 10, 2017 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.10

Comments

@rsc
Copy link
Contributor

rsc commented Nov 10, 2017

I was running all.bash and my browser popped open a tab on unused:1234. That's not acceptable.
@rsc rsc added this to the Go1.10 milestone Nov 10, 2017
@gopherbot
Copy link

Change https://golang.org/cl/76870 mentions this issue: cmd/vendor/.../pprof: do not run test that opens web browser

@rsc rsc mentioned this issue Nov 10, 2017
Closed
gopherbot pushed a commit that referenced this issue Nov 10, 2017
@rsc
cmd/vendor/.../pprof: do not run test that opens web browser
a108848 
Obviously not OK.

For #22651.

Change-Id: I4238045bec6e50788daaa27a7fbc1d547e72cde9
Reviewed-on: https://go-review.googlesource.com/76870
Run-TryBot: Russ Cox <rsc@golang.org>
Reviewed-by: Russ Cox <rsc@golang.org>
@aalexand aalexand mentioned this issue Nov 10, 2017
Merged
@rsc rsc closed this as completed Nov 22, 2017
@golang golang locked and limited conversation to collaborators Nov 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
2 participants
@rsc @gopherbot