Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/maintner: Gerrit CL and GitHub issue deletions are not reflected in model #22635

Open
andybons opened this issue Nov 8, 2017 · 5 comments
Open

x/build/maintner: Gerrit CL and GitHub issue deletions are not reflected in model #22635

andybons opened this issue Nov 8, 2017 · 5 comments
Labels
Builders x/build issues (builders, bots, dashboards)
Milestone
Unreleased

Comments

@andybons
Copy link
Member

andybons commented Nov 8, 2017

on https://dev.golang.org/release, search for Copybaraimportfromhttps. It shows CLs that have been deleted:

Copybaraimportfromhttps
  CL 72110 Copybara import from https://github.com/golang/scratch/pull/2 .
  CL 72131 Copybara import from https://github.com/golang/scratch/pull/2.
PRESUBMITforCopybarahttps
  CL 72090 PRESUBMIT for Copybara https://github.com/golang/scratch/pull/2 .
  CL 72091 PRESUBMIT for Copybara https://github.com/golang/scratch/pull/2 .

These are pulled in via ForeachOpenCL.

/cc @kevinburke @bradfitz
@gopherbot gopherbot added this to the Unreleased milestone Nov 8, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 8, 2017
@andybons andybons mentioned this issue Apr 9, 2018
Closed
@dmitshur dmitshur mentioned this issue Oct 22, 2018
Open
3 tasks
@dmitshur

This comment has been minimized.

Sign in to view
@andybons andybons mentioned this issue Mar 5, 2019
Closed
@gopherbot
Copy link

Change https://golang.org/cl/176038 mentions this issue: cmd/gopherbot: add map of deleted scratch CLs to prevent bad API calls

gopherbot pushed a commit to golang/build that referenced this issue Sep 13, 2019
@andybons
cmd/gopherbot: update map of deleted CLs to include some from scratch
0d7c512 
Updates golang/go#22635
Updates golang/go#28320

Change-Id: I8769dc83187ad1b1b2c1d751818964565f34e6d3
Reviewed-on: https://go-review.googlesource.com/c/build/+/176038
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
@gopherbot
Copy link

Change https://golang.org/cl/198118 mentions this issue: devapp: add CL 93515 to deleted list

gopherbot pushed a commit to golang/build that referenced this issue Oct 1, 2019
@andybons
devapp: add CL 93515 to deleted list
252a9ee 
Updates golang/go#22635

Change-Id: I5dc62ddda0bb54eef0c833a8ea66de3349a7871d
Reviewed-on: https://go-review.googlesource.com/c/build/+/198118
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@andybons @codebien
cmd/gopherbot: update map of deleted CLs to include some from scratch
b2d6fa8 
Updates golang/go#22635
Updates golang/go#28320

Change-Id: I8769dc83187ad1b1b2c1d751818964565f34e6d3
Reviewed-on: https://go-review.googlesource.com/c/build/+/176038
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@golang.org>
codebien pushed a commit to codebien/build that referenced this issue Nov 13, 2019
@andybons @codebien
devapp: add CL 93515 to deleted list
2ee1e2d 
Updates golang/go#22635

Change-Id: I5dc62ddda0bb54eef0c833a8ea66de3349a7871d
Reviewed-on: https://go-review.googlesource.com/c/build/+/198118
Run-TryBot: Andrew Bonventre <andybons@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Alexander Rakoczy <alex@golang.org>
@andybons andybons changed the title x/build/maintner: Gerrit CL deletions are not reflected in model x/build/maintner: Gerrit CL and GitHub issue deletions are not reflected in model Aug 6, 2020
@gopherbot
Copy link

Change https://golang.org/cl/308790 mentions this issue: cmd/gopherbot: add more deleted issues to deletedIssues map

gopherbot pushed a commit to golang/build that referenced this issue Apr 9, 2021
@dmitshur
cmd/gopherbot: add more deleted issues to deletedIssues map
da7dfab 
A good amount of time has passed since the deletedIssues map was last
updated, and the "freeze old issues" task was needlessly making 34 API
calls to freeze issues that are gone. After this change, that task is
making 0 API calls (whenever there aren't existing issues to freeze).

Some gardening tasks were converted to be more general and run on more
issue trackers in CL 233377, so update the deletedIssues map to track
the repo ID in addition to the issue number.

For golang/go#28320.
Updates golang/go#22635.
Updates golang/go#44406.
Updates golang/go#39008.

Change-Id: I3b477bf717f7d97676e9ef950214a3598ec3abd2
Reviewed-on: https://go-review.googlesource.com/c/build/+/308790
Trust: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Carlos Amedee <carlos@golang.org>
@gopherbot
Copy link

Change https://go.dev/cl/533859 mentions this issue: cmd/gopherbot: mark a block of issues as deleted

gopherbot pushed a commit to golang/build that referenced this issue Oct 10, 2023
@dmitshur @gopherbot
cmd/gopherbot: mark a block of issues as deleted
06d0829 
A number of spam issues came in at the same time and got deleted.
Handle them in bulk since they fit neatly into a linear sequence.

Updates golang/go#22635.

Change-Id: I19ec6988b2ac3fac26b0ea76660d2f0d6668e7d2
Reviewed-on: https://go-review.googlesource.com/c/build/+/533859
Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Reviewed-by: Heschi Kreinick <heschi@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards)
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @dmitshur @gopherbot