New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x/exp/shiny: Shiny does not compile on macOS #22634
Comments
you can try this cl: |
Thanks for replying. I tried applying the patch, but am getting
From what I can understand, the go and obj-c declarations are different. Would changing them work? EDIT: the patch works, thanks! Had a couple of unrelated changes which interfered and caused the above error |
I don't use a Mac for my day to day programming, and I'm not so familiar with the macOS driver for Shiny. That was mostly @crawshaw's work. Still, @tomheng's general approach looks plausible. The minus sign instead of a less than or greater than in x/exp/shiny/driver/gldriver/cocoa.m's
certainly looks a little odd, if not a bug. cl/31546 says "DO NOT SUBMIT; DO NOT REVIEW" but I'm happy to review a simple CL along those lines, especially if somebody can confirm that it works for both 10.13 High Sierra and 10.12 Sierra. Bonus points for additional confirmation on an earlier version (e.g. 10.11 El Capitan), since the existing cocoa.m code is "#if !IS_MAC_SIERRA_OR_LATER". |
I was getting this error as well. Removing the IS_MAC_SIERRA_OR_LATER check in cocoa.m fixed this issue, and I was able to build some shiny =] Go version go1.8.3 darwin/amd64 It appears as if the check isn't working for some reason, re: (NSAppKitVersionNumber - NSAppKitVersionNumber10_11) |
I tried 31546 on my Mac (High Sierra), and it seems to work here. Does anyone know why it says "DO NOT SUBMIT; DO NOT REVIEW" in the CL? |
No idea why, maybe they don't want distro specific solutions. |
I can't speak for @tomheng, but I'll repeat that, despite not using a Mac regularly, I'm happy to review a simple CL along those lines, especially if somebody can confirm that it works for both 10.13 High Sierra and 10.12 Sierra. |
@nigeltao Oh, that's what you meant? my bad, I'll test on a Sierra machine and get back to you with a PR. |
@nigeltao I had updated the CL for review, but I can only confirm it work on 10.12 Sierra, that is the |
Change https://golang.org/cl/31546 mentions this issue: |
What version of Go are you using (
go version
)?go10.9
Does this issue reproduce with the latest release?
Yes
What operating system and processor architecture are you using (
go env
)?macOS 10.13, amd64
What did you do?
go get golang.org/x/exp/shiny/driver/gldriver
What did you expect to see?
Instead of getting the package, go spawns an error
What did you see instead?
The text was updated successfully, but these errors were encountered: