Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: define how test caching interacts with timeouts #22633

Closed
rsc opened this issue Nov 8, 2017 · 1 comment
Closed

cmd/go: define how test caching interacts with timeouts #22633

rsc opened this issue Nov 8, 2017 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.10

Comments

@rsc
Copy link
Contributor

rsc commented Nov 8, 2017

@rogpeppe suggests that -timeout simply be ignored when computing the test cache key.
See https://groups.google.com/d/msg/golang-dev/qfa3mHN4ZPA/9BNft8SFAQAJ.

We need to do something with -timeout, and that seems worth trying.
@rsc rsc added this to the Go1.10 milestone Nov 8, 2017
@rsc rsc self-assigned this Nov 8, 2017
@gopherbot
Copy link

Change https://golang.org/cl/76552 mentions this issue: cmd/go: treat cached test results as satisfying any timeout

@golang golang locked and limited conversation to collaborators Nov 9, 2018
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
2 participants
@rsc @gopherbot