Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/go: test -c fails to rebuild when test changes #22632

Closed
rsc opened this issue Nov 8, 2017 · 1 comment
Closed

cmd/go: test -c fails to rebuild when test changes #22632

rsc opened this issue Nov 8, 2017 · 1 comment
Labels
FrozenDueToAge
Milestone
Go1.10

Comments

@rsc
Copy link
Contributor

rsc commented Nov 8, 2017

go test -c correctly avoids the rebuild if the test or its dependencies have not changed.
Unfortunately, it also incorrectly avoids the rebuild when the test has changed.
I ran

cd go/src/path/filepath
go test -c
add a test case to cleantests in path_test.go
go test -c

and the second go test -c did not rebuild the filepath.test in the directory.
@rsc rsc added this to the Go1.10 milestone Nov 8, 2017
@rsc rsc self-assigned this Nov 8, 2017
@rsc
Copy link
Contributor Author

rsc commented Nov 8, 2017

Actually I can't reproduce this anymore. Modifying comments correctly prevents the rebuild; modifying the test or xtest packages or the package itself does trigger a rebuild. I must have gotten confused trying different kinds of edits.

@rsc rsc closed this as completed Nov 8, 2017
@golang golang locked and limited conversation to collaborators Nov 8, 2018
@rsc rsc removed their assignment Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
2 participants
@rsc @gopherbot