Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/devapp: support R=N in Gerrit Reviews #22620

Open
andybons opened this issue Nov 7, 2017 · 3 comments
Open

x/build/devapp: support R=N in Gerrit Reviews #22620

andybons opened this issue Nov 7, 2017 · 3 comments
Labels
Builders x/build issues (builders, bots, dashboards)
Milestone
Unreleased

Comments

@andybons
Copy link
Member

andybons commented Nov 7, 2017

Previously, when a Change contained a comment with the contents “R=”, it was displayed on dev.golang.org/release. Since moving to maintner this functionality is no longer supported.

Support it again.

@TocarIP @ianlancetaylor @bradfitz
@andybons andybons self-assigned this Nov 7, 2017
@gopherbot gopherbot added this to the Unreleased milestone Nov 7, 2017
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Nov 7, 2017
@huguesb
Copy link
Contributor

huguesb commented Nov 8, 2017

It looks like that page is populated by looking at GitHub issues in some milestones and then finding CLs that reference them. Out of curiosity, why not do it the other way around, i.e. by looking at CL in tip/release branches and then the GitHub issues they reference? Or combining both approaches for maximum coverage?

@andybons
Copy link
Member Author

andybons commented Nov 8, 2017

@huguesb I would file another issue with that specific feature request, as this is meant to track a regression that was introduced when we moved to maintner.

@gopherbot
Copy link

Change https://golang.org/cl/76570 mentions this issue: devapp: don’t show issues on /release with R=close

gopherbot pushed a commit to golang/build that referenced this issue Nov 10, 2017
@andybons
devapp: don’t show issues on /release with R=close
67504a6 
This only applies if R=close is on the latest patchset.

Updates golang/go#22620

Change-Id: I097aabba2313936f1d399cdca27b510c06bffdc8
Reviewed-on: https://go-review.googlesource.com/76570
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
@andybons andybons removed their assignment Sep 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards)
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@andybons @huguesb @gopherbot