Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/compile/internal/gc: TestComparisonsConst failing on s390x #22611

Closed
mundaym opened this issue Nov 7, 2017 · 2 comments
Closed

cmd/compile/internal/gc: TestComparisonsConst failing on s390x #22611

mundaym opened this issue Nov 7, 2017 · 2 comments
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone
Go1.10

Comments

@mundaym
Copy link
Member

mundaym commented Nov 7, 2017

This started failing after ssacheck was enabled in CL 76024 (da109c6). I suspect it's because 32-bit unsigned comparisons have an aux type of Int32 when they should have an aux type of Uint32.

I'll send a CL shortly with a fix.
@mundaym mundaym self-assigned this Nov 7, 2017
@mundaym mundaym added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 7, 2017
@mundaym mundaym added this to the Go1.10 milestone Nov 7, 2017
@mundaym
Copy link
Member Author

mundaym commented Nov 7, 2017

/cc @cherrymui

@gopherbot
Copy link

Change https://golang.org/cl/76336 mentions this issue: cmd/compile: fix SSA constant typing on s390x

@golang golang locked and limited conversation to collaborators Nov 7, 2018
@rsc rsc unassigned mundaym Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Milestone
Go1.10
Development

No branches or pull requests
2 participants
@gopherbot @mundaym