-
Notifications
You must be signed in to change notification settings - Fork 17.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/vendor/github.com/google/pprof/internal/driver: TestHttpsInsecure fails #22594
Comments
It had the same issue on plan9, and it's now skipped on plan9 (see https://github.com/google/pprof/blob/79c4198ef7bd1069f8f56501fc05f0f1d2c33d8a/internal/driver/fetch_test.go#L426). We could add XP detection and Skip there, too. That said, I was surprised to learn that we still support Windows XP (we don't even have a builder for it: #10267; breakage seems inevitable). @alexbrainman Out of curiosity, is there any plan to phase off XP support? |
I did not have a chance to investigate this yet. Do you know what is broken?
I do not run Windows XP any more. But once in a while I turn my old computer on only to discover that Go still works on it (including running all.bat). So there is very little "maintenance" on my part. We can declare Windows XP as not supported, but what are we to gain from that? Alex |
AFAIK CPU profiling just doesn't work on a few system/kernels, so returned profiles are empty and the test fails. We have #13841 for this, but Windows is not mentioned here. I don't know if the root cause is the same as the one mentioned there.
That we won't have to debug and fix issues like this one any more : ) Jokes aside, I have nothing against Go still officially supporting Windows XP, I don't see many XP-related bugs filed here so it's not like XP support requires a significant amount of work. |
Thanks for the info. I will have a look when I get around to it. Alex |
I actually worked on the Windows XP builder recently. I don't have it online yet, though. |
FYI. This is how this failure looks now (go version devel +840fad1 Fri Dec 8 21:34:24 2017 +0000 windows/386):
Alex |
The linux-arm-arm5spacemonkey builder also fails in the same way with this pprof failure: https://build.golang.org/log/a73a8e17687b9a1bc3d429223d883e837a73f32a |
@alexbrainman That's the same failure (with the same error message) reported in the first message... what am I missing? The part above the |
Change https://golang.org/cl/83115 mentions this issue: |
…prof tests Updates golang/go#10267 Updates golang/go#22594 Change-Id: Ib6a9e13fbaaf4aad0b74008146b55e651658d4dd Reviewed-on: https://go-review.googlesource.com/83115 Reviewed-by: Alex Brainman <alex.brainman@gmail.com>
Change https://golang.org/cl/84035 mentions this issue: |
… arm5 Updates golang/go#19547 Updates golang/go#22594 Change-Id: I0200eebf39c1fada6c6ce146afacb9d140142c5b Reviewed-on: https://go-review.googlesource.com/84035 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
Trying to test against /debug/pprof/profile has been giving some flakes and trouble so far (google#146, google#253, google#328, golang/go#24611, golang/go#22594). While some of the discussions the failures triggered appear to be useful (such as whether CPU profiles are expected to be working on Windows XP or not), that kind of testing is not really in the scope for this particular test. This change switches the test to use goroutine profile instead which is hopefully much less dependent on the environment. The change also makes the test much faster to run.
Trying to test against /debug/pprof/profile has been giving some flakes and trouble so far (#146, #253, #328, golang/go#24611, golang/go#22594). While some of the discussions the failures triggered appear to be useful (such as whether CPU profiles are expected to be working on Windows XP or not), that kind of testing is not really in the scope for this particular test. This change switches the test to use goroutine profile instead which is hopefully much less dependent on the environment. The change also makes the test much faster to run.
Trying to test against /debug/pprof/profile has been giving some flakes and trouble so far (google#146, google#253, google#328, golang/go#24611, golang/go#22594). While some of the discussions the failures triggered appear to be useful (such as whether CPU profiles are expected to be working on Windows XP or not), that kind of testing is not really in the scope for this particular test. This change switches the test to use goroutine profile instead which is hopefully much less dependent on the environment. The change also makes the test much faster to run.
What version of Go are you using (
go version
)?go version devel +bb98331 Mon Nov 6 01:35:58 2017 +0000 windows/386
What operating system and processor architecture are you using (
go env
)?Windows XP 32 bit
What did you do?
I run
command
What did you expect to see?
What did you see instead?
Alex
The text was updated successfully, but these errors were encountered: