Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto/x509/pkix: change the semantics of the expiration of a CRL #22568

Closed
nhooyr opened this issue Nov 3, 2017 · 2 comments
Closed

crypto/x509/pkix: change the semantics of the expiration of a CRL #22568

nhooyr opened this issue Nov 3, 2017 · 2 comments
Labels
FrozenDueToAge

Comments

@nhooyr
Copy link
Contributor

nhooyr commented Nov 3, 2017

I'm talking about changing this function:

go/src/crypto/x509/pkix/pkix.go

Line 251 in d6ebbef

func (certList *CertificateList) HasExpired(now time.Time) bool {

Presently, the way CertificateList.HasExpired works is by checking whether the now time.Time argument is after the next update. However RFC 5280 Section 5, defines the nextUpdate field as the date by which the next CRL will be issued. Thus, at the nextUpdate time, the next CRL must have been issued and so the one we have now is expired. Thus, CertificateList.HasExpired should consider a CRL expired if nextUpdate is equal to now.

I've already submitted a patch for this at https://go-review.googlesource.com/c/go/+/71972
@nhooyr nhooyr changed the title crypto/x509/pkix: change semantics of the expiration of a CRL crypto/x509/pkix: change the semantics of the expiration of a CRL Nov 3, 2017
@odeke-em
Copy link
Member

odeke-em commented Nov 3, 2017

/cc @agl @FiloSottile

@agl agl self-assigned this Nov 3, 2017
@gopherbot
Copy link

Change https://golang.org/cl/71972 mentions this issue: crypto/x509/pkix: consider now==NextUpdate to be expired.

@golang golang locked and limited conversation to collaborators Nov 6, 2018
@rsc rsc unassigned agl Jun 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@agl @odeke-em @gopherbot @nhooyr