Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd/pprof: pprof update from upstream broke plan9 builders #22559

Closed
ALTree opened this issue Nov 3, 2017 · 1 comment
Closed

cmd/pprof: pprof update from upstream broke plan9 builders #22559

ALTree opened this issue Nov 3, 2017 · 1 comment
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9

Comments

@ALTree
Copy link
Member

ALTree commented Nov 3, 2017

Possibly just a matter of skipping a test that cannot work on plan9, but not sure so I'm reporting this here. It's TestHttpsInsecure, it also caused issues on nacl.

--- FAIL: TestHttpsInsecure (11.18s)
	fetch_test.go:420: fetchProfiles(https+insecure://127.0.0.1:60968/debug/pprof/profile) got non-symbolized profile: len(p.Function)==0
	fetch_test.go:376: Serve got error accept tcp 127.0.0.1:60968: open /net/tcp/22/listen: '/net/tcp/22/listen' listen hungup, want "use of closed"

https://build.golang.org/log/c580a1b0a553f12becec023170a273efca122a08

cc @0intro
@ALTree ALTree added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9 labels Nov 3, 2017
@ALTree ALTree mentioned this issue Nov 3, 2017
Closed
@ALTree
Copy link
Member Author

ALTree commented Nov 3, 2017

Fixed by CL 75870.

@ALTree ALTree closed this as completed Nov 3, 2017
@golang golang locked and limited conversation to collaborators Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Plan9
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ALTree @gopherbot