Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: windows-amd64-race builder fails with errno=1455 #22553

Open
alexbrainman opened this issue Nov 3, 2017 · 4 comments
Open

runtime: windows-amd64-race builder fails with errno=1455 #22553

alexbrainman opened this issue Nov 3, 2017 · 4 comments
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Milestone

Comments

@alexbrainman
Copy link
Member

I noticed some failures on windows-amd64-race builder:

https://build.golang.org/log/51b118b069de539851ff1cc07769de863bf47797

--- FAIL: TestRace (2.21s)
	race_test.go:71: failed to parse test output:
		# command-line-arguments_test
		runtime: VirtualAlloc of 1048576 bytes failed with errno=1455
		fatal error: out of memory
...
FAIL
FAIL	runtime/race	40.936s

and

https://build.golang.org/log/f73793faa51acd4b45e9ef88a18e462a4913448c

==2820==ERROR: ThreadSanitizer failed to allocate 0x000000400000 (4194304) bytes at 0x040177c00000 (error code: 1455)
runtime: newstack sp=0x529fdf0 stack=[0xc042200000, 0xc042202000]
	morebuf={pc:0x4083a4 sp:0x529fe00 lr:0x0}
	sched={pc:0x47bec7 sp:0x529fdf8 lr:0x0 ctxt:0x0}
runtime: gp=0xc0421ec300, gp->status=0x2
 runtime: split stack overflow: 0x529fdf0 < 0xc042200000
fatal error: runtime: split stack overflow
...
FAIL	runtime/trace	14.859s
...
--- FAIL: TestMutexMisuse (0.28s)
	mutex_test.go:173: Mutex.Unlock: did not find failure with message about unlocked lock: fork/exec C:\Users\gopher\AppData\Local\Temp\go-build022577002\b075\sync.test.exe: The paging file is too small for this operation to complete.
		
	mutex_test.go:173: Mutex.Unlock2: did not find failure with message about unlocked lock: fork/exec C:\Users\gopher\AppData\Local\Temp\go-build022577002\b075\sync.test.exe: The paging file is too small for this operation to complete.
		
	mutex_test.go:173: RWMutex.Unlock: did not find failure with message about unlocked lock: fork/exec C:\Users\gopher\AppData\Local\Temp\go-build022577002\b075\sync.test.exe: The paging file is too small for this operation to complete.
		
	mutex_test.go:173: RWMutex.Unlock2: did not find failure with message about unlocked lock: fork/exec C:\Users\gopher\AppData\Local\Temp\go-build022577002\b075\sync.test.exe: The paging file is too small for this operation to complete.
		
	mutex_test.go:173: RWMutex.Unlock3: did not find failure with message about unlocked lock: fork/exec C:\Users\gopher\AppData\Local\Temp\go-build022577002\b075\sync.test.exe: The paging file is too small for this operation to complete.
		
	mutex_test.go:173: RWMutex.RUnlock: did not find failure with message about unlocked lock: fork/exec C:\Users\gopher\AppData\Local\Temp\go-build022577002\b075\sync.test.exe: The paging file is too small for this operation to complete.
		
	mutex_test.go:173: RWMutex.RUnlock2: did not find failure with message about unlocked lock: fork/exec C:\Users\gopher\AppData\Local\Temp\go-build022577002\b075\sync.test.exe: The paging file is too small for this operation to complete.
		
	mutex_test.go:173: RWMutex.RUnlock3: did not find failure with message about unlocked lock: fork/exec C:\Users\gopher\AppData\Local\Temp\go-build022577002\b075\sync.test.exe: The paging file is too small for this operation to complete.
		
FAIL
FAIL	sync	2.803s

1455 is ERROR_COMMITMENT_LIMIT "The paging file is too small for this operation to complete."

Perhaps we just need to make builders page file larger or give PC more memory or something.

Alex

@bradfitz
Copy link
Contributor

bradfitz commented Nov 3, 2017

The Windows builders are GCE VMs of size n1-highcpu-4, which is 3.6 GB of RAM.

I'm more interested in knowing why Go now needs more than ~3 GB of RAM to compile.

@bradfitz bradfitz added this to the Go1.10 milestone Nov 3, 2017
@bradfitz bradfitz added NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows labels Nov 3, 2017
@alexbrainman
Copy link
Member Author

I'm more interested in knowing why Go now needs more than ~3 GB of RAM to compile.

I do not know. Note that this is only -race builder. Also I just submitted CL 74490 that fixed the problem where each thread used 2MB instead of 2KB of memory. But I don't see how this CL might help in scenarios I reported.

Alex

@rsc rsc modified the milestones: Go1.10, Go1.11 Nov 22, 2017
@ianlancetaylor ianlancetaylor modified the milestones: Go1.11, Go1.12 Jul 10, 2018
@andybons andybons modified the milestones: Go1.12, Go1.13 Feb 12, 2019
@andybons andybons modified the milestones: Go1.13, Go1.14 Jul 8, 2019
@rsc rsc modified the milestones: Go1.14, Backlog Oct 9, 2019
@benitogf
Copy link

benitogf commented Jun 9, 2021

hello this is showing on the github actions hosted runner: https://github.com/benitogf/level/pull/3/checks?check_run_id=2780549553#step:7:32

I tried using https://github.com/marketplace/actions/configure-pagefile to increase the pagefile but it doesn't solve the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. OS-Windows
Projects
Status: Triage Backlog
Development

No branches or pull requests

8 participants