Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/toolstash: cannot determine output file for command: compile -V=full #22552

Closed
mdempsky opened this issue Nov 2, 2017 · 2 comments
Closed

x/tools/cmd/toolstash: cannot determine output file for command: compile -V=full #22552

mdempsky opened this issue Nov 2, 2017 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@mdempsky
Copy link
Member

mdempsky commented Nov 2, 2017

Recent cmd/go changes cause it to now invoke "compile -V=full", which broke -toolexec="toolstash -cmp".
@mdempsky mdempsky added this to the Unreleased milestone Nov 2, 2017
@mdempsky mdempsky self-assigned this Nov 2, 2017
@gopherbot
Copy link

Change https://golang.org/cl/75670 mentions this issue: cmd/toolstash: don't try comparing "compile -V=full" output

@gopherbot
Copy link

Change https://golang.org/cl/75672 mentions this issue: cmd/toolstash: don't try comparing "asm -V=full" output.

gopherbot pushed a commit to golang/tools that referenced this issue Nov 2, 2017
@griesemer
cmd/toolstash: don't try comparing "asm -V=full" output.
032dfd5 
Added link as well, since they are all symmetric.

Follow-up on https://go-review.googlesource.com/c/tools/+/75670.

For golang/go#22552.

Change-Id: I12d951b800cd5fc7abc6d09e6a8a986e3f9f6936
Reviewed-on: https://go-review.googlesource.com/75672
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
@golang golang locked and limited conversation to collaborators Nov 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
2 participants
@mdempsky @gopherbot