Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/cmd/toolstash: broken after recent cmd/go changes #22548

Closed
mvdan opened this issue Nov 2, 2017 · 2 comments
Closed

x/tools/cmd/toolstash: broken after recent cmd/go changes #22548

mvdan opened this issue Nov 2, 2017 · 2 comments
Labels
FrozenDueToAge
Milestone
Unreleased

Comments

@mvdan
Copy link
Member

mvdan commented Nov 2, 2017

What version of Go are you using (go version)?

go version devel +0d101d1a9f Thu Nov 2 09:01:40 2017 +0000 linux/amd64

What did you do?

 $ go build -toolexec "toolstash -cmp" -a -v std cmd
go tool compile: exit status 1
toolstash: cannot determine output file for command: /home/mvdan/tip/pkg/tool/linux_amd64/compile -V=full

It's likely the new buildID stuff that is throwing it off:

 $ /home/mvdan/tip/pkg/tool/linux_amd64/compile -V=full
compile version devel +0d101d1a9f Thu Nov 2 09:01:40 2017 +0000 buildID=EdwHznUAy6Oxc4Hk-yFc/ale-_RqM8HqdtrWb1GOW/ikUIPRlBHr85fkjsgjLD/YuAYclRBSMsq5lIltNoC

/cc @rsc @mdempsky
@gopherbot gopherbot added this to the Unreleased milestone Nov 2, 2017
@rsc
Copy link
Contributor

rsc commented Nov 3, 2017

Fixed by https://go-review.googlesource.com/c/tools/+/75672.

@rsc rsc closed this as completed Nov 3, 2017
@mvdan
Copy link
Member Author

mvdan commented Nov 3, 2017

Ah, I see we both submitted the same issue on the same day.

@golang golang locked and limited conversation to collaborators Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@rsc @mvdan @gopherbot