Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/go: make.bash fails when GOBUILDTIMELOGFILE is set #22541

Closed
ALTree opened this issue Nov 2, 2017 · 1 comment
Closed

cmd/go: make.bash fails when GOBUILDTIMELOGFILE is set #22541

ALTree opened this issue Nov 2, 2017 · 1 comment
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Milestone

Comments

@ALTree
Copy link
Member

ALTree commented Nov 2, 2017

$ gotip version
go version devel +2dd110f9a7 Thu Nov 2 07:21:28 2017 +0000 linux/amd64

When GOBUILDTIMELOGFILE is set, make.bash logs the starting time like this:

echo $(date) start make.bash >"$GOBUILDTIMELOGFILE"

end it expect to be able to read the time back with time.Parse(time.UnixDate), but on some systems date does not print the time in time.UnixDate format. For example, if LC_TIME="en_GB.UTF-8" the default format has form Thu 2 Nov 10:20:21 CET 2017.

This causes make.bash to abort immediately:

$ GOBUILDTIMELOGFILE=~/make.log ./make.bash

2017/11/02 10:12:56 cannot parse time log line "Thu 2 Nov 10:12:55 CET 2017 start make.bash": parsing time "Thu 2 Nov 10:12:55 CET 2017" as "Mon Jan _2 15:04:05 MST 2006": cannot parse "2 Nov 10:12:55 CET 2017" as "Jan"
@gopherbot
Copy link

Change https://golang.org/cl/75370 mentions this issue: cmd/dist: fix bad LC_TIME assumption in 'date' invocation

@ALTree ALTree added the NeedsFix The path to resolution is known, but the work has not been done. label Nov 2, 2017
@ALTree ALTree added this to the Go1.10 milestone Nov 2, 2017
@golang golang locked and limited conversation to collaborators Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge NeedsFix The path to resolution is known, but the work has not been done.
Projects
None yet
Development

No branches or pull requests

2 participants